Re: [PATCH] seq_file: fix condition while loop

From: æä
Date: Fri Nov 01 2019 - 01:48:21 EST


On Thu, Oct 31, 2019 at 10:06 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Oct 31, 2019 at 07:38:21PM +0800, Yi Li wrote:
> > From: Yi Li <yilikernel@xxxxxxxxx>
> >
> > Use the break condition of loop body.
> > PTR_ERR has some meanings when p is illegal,and return 0 when p is null.
> > set the err = 0 on the next iteration if err > 0.
>
> IDGI. PTR_ERR() is not going to cause any kind of undefined behaviour for
> any valid pointer and it's trivial to evaluate. What's the point?
This patch doesn't introduce any functional changes.
Sorry for the noise..