Re: [PATCH 2/2] drm/atomic: clear new_state pointers at hw_done

[Rob Clark]

On Fri, Nov 1, 2019 at 11:33 AM Maarten Lankhorst
<maarten.lankhorst@xxxxxxxxxxxxxxx> wrote:
>
> Op 01-11-2019 om 19:07 schreef Rob Clark:
> > From: Rob Clark <robdclark@xxxxxxxxxxxx>
> >
> > The new state should not be accessed after this point.  Clear the
> > pointers to make that explicit.
> >
> > This makes the error corrected in the previous patch more obvious.
> >
> > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
>
> Would be nice if you could cc intel-gfx@xxxxxxxxxxxxxxxxxxxxx next time, so I know our CI infrastructure is happy;
>
> It wouldn't surprise me if it catches 1 or 2 abuses in i915.
>
> Otherwise Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
>
> Perhaps you could mail this to version to intel-gfx-trybot@xxxxxxxxxxxxxxxxxxxxx using git-send-email so we at least get i915 results?

ok, I sent both patches to trybot, hopefully it tries them together,
as this patch without the self-refresh fix will definitely fall over

BR,
-R