Re: [PATCH resend] i2c: core: Use DEVICE_ATTR_RW() helper macros

From: Luca Ceresoli
Date: Fri Nov 01 2019 - 18:15:48 EST


Hi Geert,

On 25/10/19 11:19, Geert Uytterhoeven wrote:
> Convert the i2c core sysfs attributes from DEVICE_ATTR() to
> DEVICE_ATTR_RW(), to reduce boilerplate.
> This requires renaming some functions.

Nitpicking: it's DEVICE_ATTR_RO and _WO, not _RW (both here and in the
subject). I'd replace with 'DEVICE_ATTR_*()'.

With this fixed:
Reviewed-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>

--
Luca