Re: [PATCH] usb: isp1760: isp1760-hcd.c: Drop condition with no effect

[Greg KH]

On Tue, Oct 29, 2019 at 02:42:14AM +0530, Saurav Girepunje wrote:
> As the "else if" and "else" branch body are identical the condition
> has no effect. So drop the "else if" condition.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>
> ---
>  drivers/usb/isp1760/isp1760-hcd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
> index 320fc4739835..579a21bd70ad 100644
> --- a/drivers/usb/isp1760/isp1760-hcd.c
> +++ b/drivers/usb/isp1760/isp1760-hcd.c
> @@ -1032,8 +1032,6 @@ static int check_atl_transfer(struct usb_hcd *hcd, struct ptd *ptd,
>  			urb->status = -EOVERFLOW;
>  		else if (FROM_DW3_CERR(ptd->dw3))
>  			urb->status = -EPIPE;  /* Stall */
> -		else if (ptd->dw3 & DW3_ERROR_BIT)
> -			urb->status = -EPROTO; /* XactErr */
>  		else
>  			urb->status = -EPROTO; /* Unknown */

Yes, the same thing happens, but look at the comment, this is two
different things.  So the code is good as-is.

thanks,

greg k-h