Re: [PATCH v2 VKMS 0/2] drm/vkms: Changing some words in 'blend' function documentation

From: Rodrigo Siqueira
Date: Mon Nov 04 2019 - 10:50:19 EST


Hi Gabriela,

In the case of this series and the patch "drm/vkms: Fix typo in function
documentation", I recommend you to use a single patch. In general, If
your changes produce a lot of deltas, you need to split them into
individual patches that modify things in logical stages. In these
patches, you made changes to some files that belong to the same patch;
thus, a single logical change is contained within a single patch.[1]

Btw, thanks for fix these issues.

Best Regards

1. https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#separate-your-changes

On 11/01, Gabriela Bittencourt wrote:
> Changes in v2:
> - Add fixing typo in word 'destination'
> - Add change of the preposition
> - In v1 the name of the function was wrong, fix it in this version
> - Add the patch changing the word 'TODO'
>
> I've tested the patches using kernel-doc
>
> Gabriela Bittencourt (2):
> drm/vkms: Fix typo and preposion in function documentation
> drm/vkms: Changing a 'Todo' to a 'TODO' in code comment
>
> drivers/gpu/drm/vkms/vkms_composer.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --
> 2.20.1
>

--
Rodrigo Siqueira
Software Engineer, Advanced Micro Devices (AMD)
https://siqueira.tech

Attachment: signature.asc
Description: PGP signature