Re: [PATCH] smpboot: reuse timer calibration

From: Thomas Gleixner
Date: Tue Nov 05 2019 - 05:06:05 EST


On Tue, 29 Oct 2019, Peter Zijlstra wrote:
> On Tue, Oct 29, 2019 at 03:19:57PM +0100, Paul Menzel wrote:
> > From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> > Date: Wed, 11 Feb 2015 17:28:14 -0600
> >
> > NO point recalibrating for known-constant tsc ...
> > saves 200ms+ of boot time.
> >
> > Signed-off-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> > ---
> >
> > Arjan, can your Signed-off-by line be added? On what device, did you test
> > this?
>
> This patch makes no sense what so ever given the current function, also
> it hard codes 0 as being the BSP.
>
> All of this for platforms (!constant_tsc) that barely exist anymore.

And it's only an issue on multi-socket systems with !constant_tsc, which
are even more rare.

Thanks,

tglx