Re: [PATCH] perf tools: Fix time sorting

From: Arnaldo Carvalho de Melo
Date: Tue Nov 05 2019 - 06:49:48 EST


Em Mon, Nov 04, 2019 at 04:48:54PM -0800, Andi Kleen escreveu:
> On Tue, Nov 05, 2019 at 12:27:11AM +0100, Jiri Olsa wrote:
> > The final sort might get confused when the comparison
> > is done over bigger numbers than int like for -s time.
> >
> > Check following report for longer workloads:
> > $ perf report -s time -F time,overhead --stdio
> >
> > Fixing hist_entry__sort to properly return int64_t and
> > not possible cut int.
> >
> > Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > Link: http://lkml.kernel.org/n/tip-uetl5z1eszpubzqykvdftaq6@xxxxxxxxxxxxxx
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
>
> Looks good.
>
> Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Thanks, applied after adding:

Fixes: 043ca389a318 ("perf tools: Use hpp formats to sort final output")
Cc: stable@xxxxxxxxxxxxxxx # v3.16+

- Arnaldo