RE: [PATCH v2 0/6] AMD64 EDAC: Check for nodes without memory, etc.

[Ghannam, Yazen]

> -----Original Message-----
> From: linux-edac-owner@xxxxxxxxxxxxxxx <linux-edac-owner@xxxxxxxxxxxxxxx> On Behalf Of Borislav Petkov
> Sent: Friday, November 1, 2019 11:54 AM
> To: Ghannam, Yazen <Yazen.Ghannam@xxxxxxx>
> Cc: linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 0/6] AMD64 EDAC: Check for nodes without memory, etc.
> 
> On Fri, Nov 01, 2019 at 03:19:36PM +0000, Ghannam, Yazen wrote:
> > Is the module being probed twice? We have this problem in general, e.g. the
> > module gets loaded multiple times on failure.
> 
> Yap, it looks like it.
> 
> > The clue for me is that node 0 gets detected twice. This is done in
> > per_family_init() early in probe_one_instance().
> >
> > In any case, I think we can make !ecc_enabled(pvt) in probe_one_instance() a
> > failure now that we have an explicit check for memory on a node. In other
> > words, if we have memory and ECC is disabled then this is a failure for the
> > module.
> 
> Yeah, for that case we should be printing ecc_msg. Makes sense.
> 

Do you have any other comments on this set? Should I send another revision
with this change?

Thanks,
Yazen