Re: [PATCH v2 01/10] staging: exfat: Clean up return codes - FFS_FORMATERR

From: Valdis KlÄtnieks
Date: Tue Nov 05 2019 - 17:21:09 EST


On Tue, 05 Nov 2019 18:05:15 +0100, Greg Kroah-Hartman said:

> This patch breaks the build:
>
> drivers/staging/exfat/exfat_super.c: In function â??ffsMountVolâ??:
> drivers/staging/exfat/exfat_super.c:387:9: error: â??FFS_FORMATERRâ?? undeclared
(first use in this function)
> 387 | ret = FFS_FORMATERR;
> | ^~~~~~~~~~~~~
>
>
> Did you test-build this thing?

Yes.

And in my tree, that section of code has:

385 /* check the validity of PBR */
386 if (GET16_A(p_pbr->signature) != PBR_SIGNATURE) {
387 brelse(tmp_bh);
388 bdev_close(sb);
389 ret = -EFSCORRUPTED;
390 goto out;
391 }

but 'git blame' says that was changed in patch 02/10 not 01/10, most likely
due to a miscue with 'git add'.

Will fix and resend.

Attachment: pgpbQSP8E2HJr.pgp
Description: PGP signature