Re: [PATCH] scripts:patch-kernel:bash syntax replace,correct one

From: Bhaskar Chowdhury
Date: Wed Nov 06 2019 - 02:01:52 EST


On 15:25 Wed 06 Nov 2019, Masahiro Yamada wrote:
On Wed, Nov 6, 2019 at 1:21 PM Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx> wrote:

On 13:15 Wed 06 Nov 2019, Masahiro Yamada wrote:
>On Fri, Oct 25, 2019 at 5:06 PM Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx> wrote:
>>
>> This patch will replace backquote to dollar parenthesis syntax
>> for better readability.Corrected one.
>
>Talking about the commit subject,
>which part is 'bash syntax' ?
>
>One more thing,
>"correct one" is not the correct way to send
>a new patch version.
>See the patch submission from other people.
>The version number is enclosed in the square brackets.
>
>[PATCH v2]
>
>
>The commit subject should describe what it does
>in imperative mood.
>
>https://patchwork.kernel.org/patch/11205593/
You are right ..my mistake ..shouldn't have included the
"correct one" ...and you are absolutely right..."bash syntax"
is as vague and confusing .

Again , Would you mind if I send you the correct one with
proper subject line and explained what changed.


I will pick up the patch with the subject corrected
but you do not need to send similar patches any more.

`...` is the correct syntax.
Even if $(...) is more readable,
the added value is quite small.

Okay , noted.



--
Best Regards
Masahiro Yamada

Attachment: signature.asc
Description: PGP signature