Re: [PATCH 4.19 059/149] iio: fix center temperature of bmc150-accel-core

From: Greg Kroah-Hartman
Date: Wed Nov 06 2019 - 05:44:18 EST


On Wed, Nov 06, 2019 at 10:41:38AM +0100, Pavel Machek wrote:
> > From: Pascal Bouwmann <bouwmann@xxxxxxxxxx>
> >
> > [ Upstream commit 6c59a962e081df6d8fe43325bbfabec57e0d4751 ]
> >
> > The center temperature of the supported devices stored in the constant
> > BMC150_ACCEL_TEMP_CENTER_VAL is not 24 degrees but 23 degrees.
> >
> > It seems that some datasheets were inconsistent on this value leading
> > to the error. For most usecases will only make minor difference so
> > not queued for stable.
> >
> > Signed-off-by: Pascal Bouwmann <bouwmann@xxxxxxxxxx>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> Minor miscalibration, and author specifically states it should not be
> queued for stable. Yet, Sasha goes and queues it for stable. Why?

Because it really does fix an issue.

thanks,

greg k-h