Re: [RFC PATCH 07/12] media: pci: cx23885: convert to i2c_new_scanned_device

From: Hans Verkuil
Date: Wed Nov 06 2019 - 06:19:03 EST


On 11/6/19 10:50 AM, Wolfram Sang wrote:
> Move from the deprecated i2c_new_probed_device() to the new
> i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Acked-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>

Regards,

Hans

> ---
>
> Build tested only. RFC, please comment and/or ack, but don't apply yet.
>
> drivers/media/pci/cx23885/cx23885-i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/pci/cx23885/cx23885-i2c.c b/drivers/media/pci/cx23885/cx23885-i2c.c
> index 4f327ee9659e..f51fad33dc04 100644
> --- a/drivers/media/pci/cx23885/cx23885-i2c.c
> +++ b/drivers/media/pci/cx23885/cx23885-i2c.c
> @@ -337,8 +337,8 @@ int cx23885_i2c_register(struct cx23885_i2c *bus)
> strscpy(info.type, "ir_video", I2C_NAME_SIZE);
> /* Use quick read command for probe, some IR chips don't
> * support writes */
> - i2c_new_probed_device(&bus->i2c_adap, &info, addr_list,
> - i2c_probe_func_quick_read);
> + i2c_new_scanned_device(&bus->i2c_adap, &info, addr_list,
> + i2c_probe_func_quick_read);
> }
>
> return bus->i2c_rc;
>