Re: [PATCH] perf/core: fix missing static inline on perf_cgroup_switch

[Mark Rutland]

On Wed, Nov 06, 2019 at 01:25:27PM +0000, Ben Dooks (Codethink) wrote:
> It looks like a "static inline" has been missed in front
> of the empty definition of perf_cgroup_switch under
> certain configurations. Fixes the following sparse warning:
> 
> kernel/events/core.c:1035:1: warning: symbol 'perf_cgroup_switch' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@xxxxxxxxxxxxxxx>
> ---
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Mark.

> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index aec8dba2bea4..a4bad9f32fb7 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -1031,7 +1031,7 @@ perf_cgroup_set_timestamp(struct task_struct *task,
>  {
>  }
>  
> -void
> +static inline void
>  perf_cgroup_switch(struct task_struct *task, struct task_struct *next)
>  {
>  }
> -- 
> 2.24.0.rc1
>