Re: [PATCH 34/50] sparc: Add show_stack_loglvl()

[Dmitry Safonov]

On 11/6/19 3:33 AM, David Miller wrote:
> From: Dmitry Safonov <dima@xxxxxxxxxx>
> Date: Wed,  6 Nov 2019 03:05:25 +0000
> 
>> Currently, the log-level of show_stack() depends on a platform
>> realization. It creates situations where the headers are printed with
>> lower log level or higher than the stacktrace (depending on
>> a platform or user).
>>
>> Furthermore, it forces the logic decision from user to an architecture
>> side. In result, some users as sysrq/kdb/etc are doing tricks with
>> temporary rising console_loglevel while printing their messages.
>> And in result it not only may print unwanted messages from other CPUs,
>> but also omit printing at all in the unlucky case where the printk()
>> was deferred.
>>
>> Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems
>> an easier approach than introducing more printk buffers.
>> Also, it will consolidate printings with headers.
>>
>> Introduce show_stack_loglvl(), that eventually will substitute
>> show_stack().
>>
>> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
>> Cc: sparclinux@xxxxxxxxxxxxxxx
>> [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@xxxxxxxxxx/T/#u
>> Signed-off-by: Dmitry Safonov <dima@xxxxxxxxxx>
> 
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

Thanks for the review and time, David!

-- 
          Dmitry