Re: [PATCH] drm/amd/powerplay: fix struct init in renoir_print_clk_levels

[Alex Deucher]

On Tue, Nov 5, 2019 at 6:10 PM Raul E Rangel <rrangel@xxxxxxxxxxxx> wrote:
>
> drivers/gpu/drm/amd/powerplay/renoir_ppt.c:186:2: error: missing braces
> around initializer [-Werror=missing-braces]
>   SmuMetrics_t metrics = {0};
>     ^
>
> Fixes: 8b8031703bd7 ("drm/amd/powerplay: implement sysfs for getting dpm clock")
>
> Signed-off-by: Raul E Rangel <rrangel@xxxxxxxxxxxx>

Applied.  thanks!

Alex

> ---
>
>  drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index e62bfba51562..e5283dafc414 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -183,11 +183,13 @@ static int renoir_print_clk_levels(struct smu_context *smu,
>         int i, size = 0, ret = 0;
>         uint32_t cur_value = 0, value = 0, count = 0, min = 0, max = 0;
>         DpmClocks_t *clk_table = smu->smu_table.clocks_table;
> -       SmuMetrics_t metrics = {0};
> +       SmuMetrics_t metrics;
>
>         if (!clk_table || clk_type >= SMU_CLK_COUNT)
>                 return -EINVAL;
>
> +       memset(&metrics, 0, sizeof(metrics));
> +
>         ret = smu_update_table(smu, SMU_TABLE_SMU_METRICS, 0,
>                                (void *)&metrics, false);
>         if (ret)
> --
> 2.24.0.rc1.363.gb1bccd3e3d-goog
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx