Re: [RESEND,PATCH 01/13] dt-bindings: mediatek: Add bindings for MT6779

From: Rob Herring
Date: Wed Nov 06 2019 - 18:40:30 EST


On Mon, 4 Nov 2019 19:52:26 +0800, Chao Hao wrote:
> This patch adds description for MT6779 IOMMU.
>
> MT6779 has two iommus, they are MM_IOMMU and APU_IOMMU which
> use ARM Short-Descriptor translation format.
>
> The MT6779 IOMMU hardware diagram is as below, it is only a brief
> diagram about iommu, it don't focus on the part of smi_larb, so
> I don't describe the smi_larb detailedly.
>
> EMI
> |
> --------------------------------------
> | |
> MM_IOMMU APU_IOMMU
> | |
> SMI_COMMOM----------- APU_BUS
> | | |
> SMI_LARB(0~11) SMI_LARB12(FAKE) SMI_LARB13(FAKE)
> | | |
> | | --------------
> | | | | |
> Multimedia engine CCU VPU MDLA EMDA
>
> All the connections are hardware fixed, software can not adjust it.
>
> >From the diagram above, MM_IOMMU provides mapping for multimedia engine,
> but CCU is connected with smi_common directly, we can take them as larb12.
> APU_IOMMU provides mapping for APU engine, we can take them larb13.
> Larb12 and Larb13 are fake larbs.
>
> Signed-off-by: Chao Hao <chao.hao@xxxxxxxxxxxx>
> ---
> .../bindings/iommu/mediatek,iommu.txt | 2 +
> include/dt-bindings/memory/mt6779-larb-port.h | 217 ++++++++++++++++++
> 2 files changed, 219 insertions(+)
> create mode 100644 include/dt-bindings/memory/mt6779-larb-port.h
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>