Re: [PATCH v4 00/10] Rework REFCOUNT_FULL using atomic_fetch_* operations

From: Will Deacon
Date: Thu Nov 07 2019 - 08:01:07 EST


On Wed, Oct 30, 2019 at 11:40:56AM -0700, Kees Cook wrote:
> On Wed, Oct 30, 2019 at 02:30:25PM +0000, Will Deacon wrote:
> > Hi all,
> >
> > This is version four of the patches I previously posted here:
> >
> > v1: https://lkml.kernel.org/r/20190802101000.12958-1-will@xxxxxxxxxx
> > v2: https://lkml.kernel.org/r/20190827163204.29903-1-will@xxxxxxxxxx
> > v3: https://lkml.kernel.org/r/20191007154703.5574-1-will@xxxxxxxxxx
> >
> > Changes since v3 include:
> >
> > - Add description of racy behaviour include/linux/refcount.h
> > - Fix saturation behaviour in refcount_sub_and_test()
> > - Added Acks and Tested-bys
>
> Thanks again for this! I think this series is in good shape; I'm glad we
> can sanely expand these protections.

Cheers, Kees.

Peter -- are you ok with this version? I think I've addressed all of your
concerns from v3, including the addition of ASCII-art to explain the
saturation behaviour (I can use .rst instead if you prefer).

Will