Re: [PATCH v7 0/7] perf report: Support sorting all blocks by cycles

[Jin, Yao]

On 11/7/2019 5:28 PM, Jiri Olsa wrote:
> On Thu, Nov 07, 2019 at 03:47:12PM +0800, Jin Yao wrote:
> > It would be useful to support sorting for all blocks by the
> > sampled cycles percent per block. This is useful to concentrate
> > on the globally hottest blocks.
> >
> > This patch series implements a new option "--total-cycles" which
> > sorts all blocks by 'Sampled Cycles%'. The 'Sampled Cycles%' is
> > block sampled cycles aggregation / total sampled cycles
> >
> > For example,
> >
> > perf record -b ./div
> > perf report --total-cycles --stdio
> >
> >   # To display the perf.data header info, please use --header/--header-only options.
> >   #
> >   #
> >   # Total Lost Samples: 0
> >   #
> >   # Samples: 2M of event 'cycles'
> >   # Event count (approx.): 2753248
> >   #
> >   # Sampled Cycles%  Sampled Cycles  Avg Cycles%  Avg Cycles                                              [Program Block Range]         Shared Object
> >   # ...............  ..............  ...........  ..........  .................................................................  ....................
> >   #
> >              26.04%            2.8M        0.40%          18                                             [div.c:42 -> div.c:39]                   div
> >              15.17%            1.2M        0.16%           7                                 [random_r.c:357 -> random_r.c:380]          libc-2.27.so
> >               5.11%          402.0K        0.04%           2                                             [div.c:27 -> div.c:28]                   div
> >               4.87%          381.6K        0.04%           2                                     [random.c:288 -> random.c:291]          libc-2.27.so
> >               4.53%          381.0K        0.04%           2                                             [div.c:40 -> div.c:40]                   div
> >               3.85%          300.9K        0.02%           1                                             [div.c:22 -> div.c:25]                   div
> >               3.08%          241.1K        0.02%           1                                           [rand.c:26 -> rand.c:27]          libc-2.27.so
> >               3.06%          240.0K        0.02%           1                                     [random.c:291 -> random.c:291]          libc-2.27.so
> >               2.78%          215.7K        0.02%           1                                     [random.c:298 -> random.c:298]          libc-2.27.so
> >               2.52%          198.3K        0.02%           1                                     [random.c:293 -> random.c:293]          libc-2.27.so
> >               2.36%          184.8K        0.02%           1                                           [rand.c:28 -> rand.c:28]          libc-2.27.so
> >               2.33%          180.5K        0.02%           1                                     [random.c:295 -> random.c:295]          libc-2.27.so
> >               2.28%          176.7K        0.02%           1                                     [random.c:295 -> random.c:295]          libc-2.27.so
> >               2.20%          168.8K        0.02%           1                                         [rand@plt+0 -> rand@plt+0]                   div
> >               1.98%          158.2K        0.02%           1                                 [random_r.c:388 -> random_r.c:388]          libc-2.27.so
> >               1.57%          123.3K        0.02%           1                                             [div.c:42 -> div.c:44]                   div
> >               1.44%          116.0K        0.42%          19                                 [random_r.c:357 -> random_r.c:394]          libc-2.27.so
> >   ......
> >
> > This patch series supports both stdio and tui. And also with the supporting
> > of --percent-limit.
> >
> >   v7:
> >   ---
> >   Use use_browser in report__browse_block_hists and support
> >   reporting for both stdio and tui modes.
> >   
> >   Move block tui browser code from ui/browsers/hists.c
> >   to block-info.c.
>
> thanks for bearing with me ;-)
>
> Reviewed-by: Jiri Olsa <jolsa@xxxxxxxxxx>
>
> jirka

Hi Jiri,

I really appreciate your help! Your review comments really let the v7 be 
much better than the initial version.

Thanks
Jin Yao