Re: [PATCH v2 08/11] dt-bindings: fsi: Add description of FSI master

From: Greg KH
Date: Fri Nov 08 2019 - 05:28:16 EST


On Fri, Nov 08, 2019 at 03:49:42PM +1030, Joel Stanley wrote:
> This describes the FSI master present in the AST2600.
>
> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
> Acked-by: Alistair Popple <alistair@xxxxxxxxxxxx>
> ---
> .../bindings/fsi/fsi-master-aspeed.txt | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
>
> diff --git a/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt b/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
> new file mode 100644
> index 000000000000..b758f91914f7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
> @@ -0,0 +1,24 @@
> +Device-tree bindings for AST2600 FSI master
> +-------------------------------------------
> +
> +The AST2600 contains two identical FSI masters. They share a clock and have a
> +separate interrupt line and output pins.
> +
> +Required properties:
> + - compatible: "aspeed,ast2600-fsi-master"
> + - reg: base address and length
> + - clocks: phandle and clock number
> + - interrupts: platform dependent interrupt description
> + - pinctrl-0: phandle to pinctrl node
> + - pinctrl-names: pinctrl state
> +
> +Examples:
> +
> + fsi-master {
> + compatible = "aspeed,ast2600-fsi-master", "fsi-master";
> + reg = <0x1e79b000 0x94>;
> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_fsi1_default>;
> + clocks = <&syscon ASPEED_CLK_GATE_FSICLK>;
> + };
> --
> 2.24.0.rc1
>

As these all seem like bog-standard properties, I'll take this now,
thanks.

greg k-h