Re: [alsa-devel] [PATCH 07/14] soundwire: add initial definitions for sdw_master_device

[Pierre-Louis Bossart]

On 11/7/19 10:04 PM, Vinod Koul wrote:
> On 04-11-19, 08:42, Pierre-Louis Bossart wrote:
> > On 11/3/19 1:30 AM, Vinod Koul wrote:
> > > On 23-10-19, 16:28, Pierre-Louis Bossart wrote:
> > > > Since we want an explicit support for the SoundWire Master device, add
> > > > the definitions, following the Grey Bus example.
> > > >
> > > > Open: do we need to set a variable when dealing with the master uevent?
> > >
> > > I dont think we want that or we need that!
> >
> > In GreyBus there are events and variables set, not sure what they were used
> > for. The code works without setting an event, but we'd need to make a
> > conscious design decision, and I am not too sure what usersace would use the
> > informatio for.
> >
> > > And to prevent that rather than adding a variable, can you please
> > > modify the device_type and use separate ones for master_device and
> > > slave_device
> >
> > sorry, I don't get the comment. There is only already a different device
> > type
> >
> >
> > struct bus_type sdw_bus_type = {
> > 	.name = "soundwire",
> > 	.match = sdw_bus_match,
> > 	.uevent = sdw_uevent,
>
> We can remove this
>
> > };
> >
> > struct device_type sdw_slave_type = {
> > 	.name =		"sdw_slave",
> > 	.release =	sdw_slave_release,
>
> Add here:
>
>          uevent = sdw_uevent,
>
> > };
> >
> > struct device_type sdw_md_type = {
> > 	.name =		"soundwire_master",
> > 	.release =	sdw_md_release,
> > };
>
> And not have here!
>
> Problem solved!

I will give it a try but I don't know what the 'problem' was.
The code works as is, and btw you are commenting on the wrong version of 
the series, v2 was sent yesterday.