Re: [PATCH][next] drm/amd/display: remove duplicated assignment to grph_obj_type

[Alex Deucher]

On Fri, Nov 8, 2019 at 9:45 AM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Variable grph_obj_type is being assigned twice, one of these is
> redundant so remove it.
>
> Addresses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Applied.  Thanks!

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> index be6d0cfe41ae..9ba80d828876 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
> @@ -365,8 +365,7 @@ bool amdgpu_atombios_get_connector_info_from_object_table(struct amdgpu_device *
>                         router.ddc_valid = false;
>                         router.cd_valid = false;
>                         for (j = 0; j < ((le16_to_cpu(path->usSize) - 8) / 2); j++) {
> -                               uint8_t grph_obj_type=
> -                               grph_obj_type =
> +                               uint8_t grph_obj_type =
>                                     (le16_to_cpu(path->usGraphicObjIds[j]) &
>                                      OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT;
>
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel