Re: [Patch v2 3/5] ARM: dts: dra7: add vpe clkctrl node

[Benoit Parrot]

Tony Lindgren <tony@xxxxxxxxxxx> wrote on Fri [2019-Nov-08 08:55:54 -0800]:
> Hi,
> 
> * Benoit Parrot <bparrot@xxxxxx> [191104 20:39]:
> > Add clkctrl nodes for VPE module.
> 
> Can you please add a comment describing that we currently need to
> use custom node names here instead of the standard naming?

Tony, what do you mean "custom node name" here?
I followed the exact same syntax that was already there... confused..

Benoit

> 
> I can queue this and other dts change once I have an immutable clock
> changes branch from Tero.
> 
> Or if Tero wants to also pick up the clock node dtsi patch I can ack it,
> up to Tero.
> 
> Regards,
> 
> Tony
> 
> 
> > Signed-off-by: Benoit Parrot <bparrot@xxxxxx>
> > ---
> >  arch/arm/boot/dts/dra7xx-clocks.dtsi | 18 ++++++++++++++++--
> >  1 file changed, 16 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> > index 93e1eb83bed9..d1c2406ec71c 100644
> > --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> > +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> > @@ -1591,10 +1591,10 @@
> >  
> >  	rtc_cm: rtc-cm@700 {
> >  		compatible = "ti,omap4-cm";
> > -		reg = <0x700 0x100>;
> > +		reg = <0x700 0x60>;
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > -		ranges = <0 0x700 0x100>;
> > +		ranges = <0 0x700 0x60>;
> >  
> >  		rtc_clkctrl: rtc-clkctrl@20 {
> >  			compatible = "ti,clkctrl";
> > @@ -1603,6 +1603,20 @@
> >  		};
> >  	};
> >  
> > +	vpe_cm: vpe-cm@760 {
> > +		compatible = "ti,omap4-cm";
> > +		reg = <0x760 0xc>;
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0 0x760 0xc>;
> > +
> > +		vpe_clkctrl: vpe-clkctrl@0 {
> > +			compatible = "ti,clkctrl";
> > +			reg = <0x0 0xc>;
> > +			#clock-cells = <2>;
> > +		};
> > +	};
> > +
> >  };
> >  
> >  &cm_core {
> > -- 
> > 2.17.1
> >