Re: [Letux-kernel] [PATCH 2/2] ARM: dts: add devicetree entry for Tolino Shine 3

From: H. Nikolaus Schaller
Date: Fri Nov 08 2019 - 13:34:59 EST


> Am 08.11.2019 um 12:18 schrieb Andreas Kemnade <andreas@xxxxxxxxxxxx>:
>
> The device is almost identical to the Kobo Clara HD. The only
> spotted difference is the SoC. It contains an imx6sl
> instead of an imx6sll.
>
> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 326 +++++++++++++++++++++++++++++
> 2 files changed, 327 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6sl-tolino-shine3.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index f969c37729d5..1486615470b2 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -550,6 +550,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> imx6qp-zii-rdu2.dtb
> dtb-$(CONFIG_SOC_IMX6SL) += \
> imx6sl-evk.dtb \
> + imx6sl-tolino-shine3.dtb \
> imx6sl-warp.dtb
> dtb-$(CONFIG_SOC_IMX6SLL) += \
> imx6sll-evk.dtb \
> diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> new file mode 100644
> index 000000000000..0ee49258f22c
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> @@ -0,0 +1,326 @@
> +// SPDX-License-Identifier: (GPL-2.0)
> +/*
> + * Device tree for the Tolino Shine 3 ebook reader
> + *
> + * Name on mainboard is: 37NB-E60K00+4A4
> + * Serials start with: E60K02 (a number also seen in
> + * vendor kernel sources)
> + *
> + * This mainboard seems to be equipped with different SoCs.
> + * In the Toline Shine 3 ebook reader it is a i.MX6SL
> + *
> + * Copyright 2019 Andreas Kemnade
> + * based on works
> + * Copyright 2016 Freescale Semiconductor, Inc.
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include "imx6sl.dtsi"
> +#include "e60k02.dtsi"
> +
> +/ {
> + model = "Tolino Shine 3";
> + compatible = "kobo,tolino-shine3", "fsl,imx6sl";
> +};
> +
> +&gpio_keys {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_keys>;
> +};
> +
> +&i2c1 {
> + pinctrl-names = "default","sleep";
> + pinctrl-0 = <&pinctrl_i2c1>;
> + pinctrl-1 = <&pinctrl_i2c1_sleep>;
> +};
> +
> +&i2c2 {
> + pinctrl-names = "default","sleep";
> + pinctrl-0 = <&pinctrl_i2c2>;
> + pinctrl-1 = <&pinctrl_i2c2_sleep>;
> +};
> +
> +&i2c3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c3>;
> +};
> +
> +&iomuxc {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_hog>;
> +
> + pinctrl_gpio_keys: gpio-keysgrp {
> + fsl,pins = <
> + MX6SL_PAD_SD1_DAT1__GPIO5_IO08 0x17059 /* PWR_SW */
> + MX6SL_PAD_SD1_DAT4__GPIO5_IO12 0x17059 /* HALL_EN */
> + >;
> + };
> +
> + pinctrl_hog: hoggrp {
> + fsl,pins = <
> + MX6SL_PAD_LCD_DAT0__GPIO2_IO20 0x79
> + MX6SL_PAD_LCD_DAT1__GPIO2_IO21 0x79
> + MX6SL_PAD_LCD_DAT2__GPIO2_IO22 0x79
> + MX6SL_PAD_LCD_DAT3__GPIO2_IO23 0x79
> + MX6SL_PAD_LCD_DAT4__GPIO2_IO24 0x79
> + MX6SL_PAD_LCD_DAT5__GPIO2_IO25 0x79
> + MX6SL_PAD_LCD_DAT6__GPIO2_IO26 0x79
> + MX6SL_PAD_LCD_DAT7__GPIO2_IO27 0x79
> + MX6SL_PAD_LCD_DAT8__GPIO2_IO28 0x79
> + MX6SL_PAD_LCD_DAT9__GPIO2_IO29 0x79
> + MX6SL_PAD_LCD_DAT10__GPIO2_IO30 0x79
> + MX6SL_PAD_LCD_DAT11__GPIO2_IO31 0x79
> + MX6SL_PAD_LCD_DAT12__GPIO3_IO00 0x79
> + MX6SL_PAD_LCD_DAT13__GPIO3_IO01 0x79
> + MX6SL_PAD_LCD_DAT14__GPIO3_IO02 0x79
> + MX6SL_PAD_LCD_DAT15__GPIO3_IO03 0x79
> + MX6SL_PAD_LCD_DAT16__GPIO3_IO04 0x79
> + MX6SL_PAD_LCD_DAT17__GPIO3_IO05 0x79
> + MX6SL_PAD_LCD_DAT18__GPIO3_IO06 0x79
> + MX6SL_PAD_LCD_DAT19__GPIO3_IO07 0x79
> + MX6SL_PAD_LCD_DAT20__GPIO3_IO08 0x79
> + MX6SL_PAD_LCD_DAT21__GPIO3_IO09 0x79
> + MX6SL_PAD_LCD_DAT22__GPIO3_IO10 0x79
> + MX6SL_PAD_LCD_DAT23__GPIO3_IO11 0x79
> + MX6SL_PAD_LCD_CLK__GPIO2_IO15 0x79
> + MX6SL_PAD_LCD_ENABLE__GPIO2_IO16 0x79
> + MX6SL_PAD_LCD_HSYNC__GPIO2_IO17 0x79
> + MX6SL_PAD_LCD_VSYNC__GPIO2_IO18 0x79
> + MX6SL_PAD_LCD_RESET__GPIO2_IO19 0x79
> + MX6SL_PAD_KEY_COL3__GPIO3_IO30 0x79
> + MX6SL_PAD_KEY_ROW7__GPIO4_IO07 0x79
> + MX6SL_PAD_ECSPI2_MOSI__GPIO4_IO13 0x79
> + MX6SL_PAD_KEY_COL5__GPIO4_IO02 0x79
> + MX6SL_PAD_KEY_ROW6__GPIO4_IO05 0x79
> + >;
> + };
> +
> + pinctrl_i2c1: i2c1grp {
> + fsl,pins = <
> + MX6SL_PAD_I2C1_SCL__I2C1_SCL 0x4001f8b1
> + MX6SL_PAD_I2C1_SDA__I2C1_SDA 0x4001f8b1
> + >;
> + };
> +
> + pinctrl_i2c1_sleep: i2c1grp-sleep {
> + fsl,pins = <
> + MX6SL_PAD_I2C1_SCL__I2C1_SCL 0x400108b1
> + MX6SL_PAD_I2C1_SDA__I2C1_SDA 0x400108b1
> + >;
> + };
> +
> + pinctrl_i2c2: i2c2grp {
> + fsl,pins = <
> + MX6SL_PAD_I2C2_SCL__I2C2_SCL 0x4001f8b1
> + MX6SL_PAD_I2C2_SDA__I2C2_SDA 0x4001f8b1
> + >;
> + };
> +
> + pinctrl_i2c2_sleep: i2c2grp-sleep {
> + fsl,pins = <
> + MX6SL_PAD_I2C2_SCL__I2C2_SCL 0x400108b1
> + MX6SL_PAD_I2C2_SDA__I2C2_SDA 0x400108b1
> + >;
> + };
> +
> + pinctrl_i2c3: i2c3grp {
> + fsl,pins = <
> + MX6SL_PAD_REF_CLK_24M__I2C3_SCL 0x4001f8b1
> + MX6SL_PAD_REF_CLK_32K__I2C3_SDA 0x4001f8b1
> + >;
> + };
> +
> + pinctrl_led: ledgrp {
> + fsl,pins = <
> + MX6SL_PAD_SD1_DAT6__GPIO5_IO07 0x17059
> + >;
> + };
> +
> + pinctrl_lm3630a_bl_gpio: lm3630a-bl-gpiogrp {
> + fsl,pins = <
> + MX6SL_PAD_EPDC_PWRCTRL3__GPIO2_IO10 0x10059 /* HWEN */
> + >;
> + };
> +
> + pinctrl_ricoh_gpio: ricoh_gpiogrp {
> + fsl,pins = <
> + MX6SL_PAD_SD1_CLK__GPIO5_IO15 0x1b8b1 /* ricoh619 chg */
> + MX6SL_PAD_SD1_DAT0__GPIO5_IO11 0x1b8b1 /* ricoh619 irq */
> + MX6SL_PAD_KEY_COL2__GPIO3_IO28 0x1b8b1 /* ricoh619 bat_low_int */
> + >;
> + };
> +
> + pinctrl_uart1: uart1grp {
> + fsl,pins = <
> + MX6SL_PAD_UART1_TXD__UART1_TX_DATA 0x1b0b1
> + MX6SL_PAD_UART1_RXD__UART1_TX_DATA 0x1b0b1
> + >;
> + };
> +
> + pinctrl_usbotg1: usbotg1grp {
> + fsl,pins = <
> + MX6SL_PAD_EPDC_PWRCOM__USB_OTG1_ID 0x17059
> + >;
> + };
> +
> + pinctrl_usdhc2: usdhc2grp {
> + fsl,pins = <
> + MX6SL_PAD_SD2_CMD__SD2_CMD 0x17059
> + MX6SL_PAD_SD2_CLK__SD2_CLK 0x13059
> + MX6SL_PAD_SD2_DAT0__SD2_DATA0 0x17059
> + MX6SL_PAD_SD2_DAT1__SD2_DATA1 0x17059
> + MX6SL_PAD_SD2_DAT2__SD2_DATA2 0x17059
> + MX6SL_PAD_SD2_DAT3__SD2_DATA3 0x17059
> + >;
> + };
> +
> + pinctrl_usdhc2_100mhz: usdhc2grp-100mhz {
> + fsl,pins = <
> + MX6SL_PAD_SD2_CMD__SD2_CMD 0x170b9
> + MX6SL_PAD_SD2_CLK__SD2_CLK 0x130b9
> + MX6SL_PAD_SD2_DAT0__SD2_DATA0 0x170b9
> + MX6SL_PAD_SD2_DAT1__SD2_DATA1 0x170b9
> + MX6SL_PAD_SD2_DAT2__SD2_DATA2 0x170b9
> + MX6SL_PAD_SD2_DAT3__SD2_DATA3 0x170b9
> + >;
> + };
> +
> + pinctrl_usdhc2_200mhz: usdhc2grp-200mhz {
> + fsl,pins = <
> + MX6SL_PAD_SD2_CMD__SD2_CMD 0x170f9
> + MX6SL_PAD_SD2_CLK__SD2_CLK 0x130f9
> + MX6SL_PAD_SD2_DAT0__SD2_DATA0 0x170f9
> + MX6SL_PAD_SD2_DAT1__SD2_DATA1 0x170f9
> + MX6SL_PAD_SD2_DAT2__SD2_DATA2 0x170f9
> + MX6SL_PAD_SD2_DAT3__SD2_DATA3 0x170f9
> + >;
> + };
> +
> + pinctrl_usdhc2_sleep: usdhc2grp-sleep {
> + fsl,pins = <
> + MX6SL_PAD_SD2_CMD__GPIO5_IO04 0x100f9
> + MX6SL_PAD_SD2_CLK__GPIO5_IO05 0x100f9
> + MX6SL_PAD_SD2_DAT0__GPIO5_IO01 0x100f9
> + MX6SL_PAD_SD2_DAT1__GPIO4_IO30 0x100f9
> + MX6SL_PAD_SD2_DAT2__GPIO5_IO03 0x100f9
> + MX6SL_PAD_SD2_DAT3__GPIO4_IO28 0x100f9
> + >;
> + };
> +
> + pinctrl_usdhc3: usdhc3grp {
> + fsl,pins = <
> + MX6SL_PAD_SD3_CMD__SD3_CMD 0x11059
> + MX6SL_PAD_SD3_CLK__SD3_CLK 0x11059
> + MX6SL_PAD_SD3_DAT0__SD3_DATA0 0x11059
> + MX6SL_PAD_SD3_DAT1__SD3_DATA1 0x11059
> + MX6SL_PAD_SD3_DAT2__SD3_DATA2 0x11059
> + MX6SL_PAD_SD3_DAT3__SD3_DATA3 0x11059
> + >;
> + };
> +
> + pinctrl_usdhc3_100mhz: usdhc3grp-100mhz {
> + fsl,pins = <
> + MX6SL_PAD_SD3_CMD__SD3_CMD 0x170b9
> + MX6SL_PAD_SD3_CLK__SD3_CLK 0x170b9
> + MX6SL_PAD_SD3_DAT0__SD3_DATA0 0x170b9
> + MX6SL_PAD_SD3_DAT1__SD3_DATA1 0x170b9
> + MX6SL_PAD_SD3_DAT2__SD3_DATA2 0x170b9
> + MX6SL_PAD_SD3_DAT3__SD3_DATA3 0x170b9
> + >;
> + };
> +
> + pinctrl_usdhc3_200mhz: usdhc3grp-200mhz {
> + fsl,pins = <
> + MX6SL_PAD_SD3_CMD__SD3_CMD 0x170f9
> + MX6SL_PAD_SD3_CLK__SD3_CLK 0x170f9
> + MX6SL_PAD_SD3_DAT0__SD3_DATA0 0x170f9
> + MX6SL_PAD_SD3_DAT1__SD3_DATA1 0x170f9
> + MX6SL_PAD_SD3_DAT2__SD3_DATA2 0x170f9
> + MX6SL_PAD_SD3_DAT3__SD3_DATA3 0x170f9
> + >;
> + };
> +
> + pinctrl_usdhc3_sleep: usdhc3grp-sleep {
> + fsl,pins = <
> + MX6SL_PAD_SD3_CMD__GPIO5_IO21 0x100c1
> + MX6SL_PAD_SD3_CLK__GPIO5_IO18 0x100c1
> + MX6SL_PAD_SD3_DAT0__GPIO5_IO19 0x100c1
> + MX6SL_PAD_SD3_DAT1__GPIO5_IO20 0x100c1
> + MX6SL_PAD_SD3_DAT2__GPIO5_IO16 0x100c1
> + MX6SL_PAD_SD3_DAT3__GPIO5_IO17 0x100c1
> + >;
> + };
> +
> + pinctrl_wifi_power: wifi-powergrp {
> + fsl,pins = <
> + MX6SL_PAD_SD2_DAT6__GPIO4_IO29 0x10059 /* WIFI_3V3_ON */
> + >;
> + };
> +
> + pinctrl_wifi_reset: wifi-resetgrp {
> + fsl,pins = <
> + MX6SL_PAD_SD2_DAT7__GPIO5_IO00 0x10059 /* WIFI_RST */
> + >;
> + };
> +};
> +
> +&leds {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_led>;
> +};
> +
> +&lm3630a {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lm3630a_bl_gpio>;
> +};
> +
> +&reg_wifi {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_wifi_power>;
> +};
> +
> +&reg_vdd1p1 {
> + vin-supply = <&dcdc2_reg>;
> +};
> +
> +&reg_vdd2p5 {
> + vin-supply = <&dcdc2_reg>;
> +};
> +
> +&reg_vdd3p0 {
> + vin-supply = <&dcdc2_reg>;
> +};
> +
> +&ricoh619 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ricoh_gpio>;
> +};
> +
> +&uart1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart1>;
> +};
> +
> +&usdhc2 {
> + pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
> + pinctrl-0 = <&pinctrl_usdhc2>;
> + pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
> + pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
> + pinctrl-3 = <&pinctrl_usdhc2_sleep>;
> +};
> +
> +&usdhc3 {
> + pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
> + pinctrl-0 = <&pinctrl_usdhc3>;
> + pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> + pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> + pinctrl-3 = <&pinctrl_usdhc3_sleep>;
> +};
> +
> +&wifi_pwrseq {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_wifi_reset>;
> +};
> --
> 2.11.0

Tested-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> # Tolino Shine3