Re: [PATCH V2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l

[kgunda]

On 2019-11-06 22:08, Stephen Boyd wrote:
> Quoting Kiran Gunda (2019-11-04 21:21:49)
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt 
> > b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > index 1437062..b5fc64e 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> > @@ -32,6 +32,8 @@ Required properties:
> >                     "qcom,pm8998",
> >                     "qcom,pmi8998",
> >                     "qcom,pm8005",
> > +                  "qcom,pm6150",
> > +                  "qcom,pm6150l",
>
> This seems to match the compatible list in the driver. Can you convert
> this binding to YAML and then sort this compatible string list
> alpha-numberically? Two patches, one to convert to YAML and sort and
> another patch to add these new compatible strings.
Sure. Will do it.
> >                     or generalized "qcom,spmi-pmic".
> >  - reg:             Specifies the SPMI USID slave address for this 
> > device.
> >                     For more information see:
> > diff --git a/drivers/mfd/qcom-spmi-pmic.c 
> > b/drivers/mfd/qcom-spmi-pmic.c
> > index e8fe705..74b7980 100644
> > --- a/drivers/mfd/qcom-spmi-pmic.c
> > +++ b/drivers/mfd/qcom-spmi-pmic.c
> > @@ -34,6 +34,8 @@
> >  #define PM8998_SUBTYPE         0x14
> >  #define PMI8998_SUBTYPE                0x15
> >  #define PM8005_SUBTYPE         0x18
> > +#define PM6150_SUBTYPE         0x28
> > +#define PM6150L_SUBTYPE                0x27
>
> This list looks to be sorted based on id number, so just swap the two
> here.
Ok. Will do it in next post.
> >  static const struct of_device_id pmic_spmi_id_table[] = {
> >         { .compatible = "qcom,spmi-pmic", .data = (void 
> > *)COMMON_SUBTYPE },
> > @@ -53,6 +55,8 @@
> >         { .compatible = "qcom,pm8998",    .data = (void 
> > *)PM8998_SUBTYPE },
> >         { .compatible = "qcom,pmi8998",   .data = (void 
> > *)PMI8998_SUBTYPE },
> >         { .compatible = "qcom,pm8005",    .data = (void 
> > *)PM8005_SUBTYPE },
> > +       { .compatible = "qcom,pm6150",    .data = (void 
> > *)PM6150_SUBTYPE },
> > +       { .compatible = "qcom,pm6150l",   .data = (void 
> > *)PM6150L_SUBTYPE },
>
> This is also sorted based on .data value, so swap the two here too.
Ok. Will do it in next post.
> >         { }