Re: [alsa-devel] [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

From: Shengjiu Wang
Date: Mon Nov 11 2019 - 02:37:54 EST


Hi

On Sat, Nov 9, 2019 at 10:48 AM Nicolin Chen <nicoleotsuka@xxxxxxxxx> wrote:
>
> On Wed, Nov 06, 2019 at 03:27:45PM +0800, Shengjiu Wang wrote:
> > Audmix support two substream, When two substream start
> > to run, the trigger function may be called by two substream
> > in same time, that the priv->tdms may be updated wrongly.
> >
> > The expected priv->tdms is 0x3, but sometimes the
> > result is 0x2, or 0x1.
>
> Feels like a bug fix to me, so might be better to have a "Fixes"
> line and CC stable tree?
>
> Anyway, change looks good to me:
>
> Acked-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>
>

Ok, will send v2.

best regards
wang shengjiu