Re: [PATCH 40/62] gpio: gpio-siox: Use new GPIO_LINE_DIRECTION

[Thorsten Scherer]

Hello,

On Tue, Nov 05, 2019 at 12:30:58PM +0200, Matti Vaittinen wrote:
> It's hard for occasional GPIO code reader/writer to know if values 0/1
> equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
> GPIO_LINE_DIRECTION_OUT to help them out.
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>

for SIOX gpio:

Acked-by: Thorsten Scherer <t.scherer@xxxxxxxxxxxx>

> ---
>  drivers/gpio/gpio-siox.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-siox.c b/drivers/gpio/gpio-siox.c
> index 006a7e6a75f2..311f66757b92 100644
> --- a/drivers/gpio/gpio-siox.c
> +++ b/drivers/gpio/gpio-siox.c
> @@ -203,9 +203,9 @@ static int gpio_siox_direction_output(struct gpio_chip *chip,
>  static int gpio_siox_get_direction(struct gpio_chip *chip, unsigned int offset)
>  {
>  	if (offset < 12)
> -		return 1; /* input */
> +		return GPIO_LINE_DIRECTION_IN;
>  	else
> -		return 0; /* output */
> +		return GPIO_LINE_DIRECTION_OUT;
>  }
>  
>  static int gpio_siox_probe(struct siox_device *sdevice)
> -- 
> 2.21.0
> 

> Quoted from
> [PATCH 00/62] Add definition for GPIO direction
> <cover.1572875541.git.matti.vaittinen@xxxxxxxxxxxxxxxxx>
>
> Patches are compile-tested only. I have no HW to really test them.  Thus
> I'd appreciate carefull review. This work is mainly about converting
> zeros and ones to the new defines but it wouldn't be first time I
> get it wrong in one of the patches :)                                                   

Applied the patch(es) and tested them with SIOX device

Tested-by: Thorsten Scherer <t.scherer@xxxxxxxxxxxx>

> 
> -- 
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
> 
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =]