Re: [PATCH] drm/amd/display: remove duplicated comparison expression

[Kazlauskas, Nicholas]

On 2019-11-09 10:49 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> There is comparison expression that is duplicated and hence one
> of the expressions can be removed.  Remove it.
>
> Addresses-Coverity: ("Same on both sides")
> Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>

Thanks!

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 1fdba13b3d0f..1fa255e077d0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
>   	}
>   
>   	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> -			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
>   			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
>   		update_flags->bits.plane_size_change = 1;
>   		elevate_update_type(&update_type, UPDATE_TYPE_MED);