Re: [PATCH] sparc: vdso: Fix build failure seen due to kbuild changes

[Guenter Roeck]

On 11/10/19 5:47 PM, Masahiro Yamada wrote:
> On Mon, Nov 11, 2019 at 10:32 AM David Miller <davem@xxxxxxxxxxxxx> wrote:
> > From: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Date: Sun, 10 Nov 2019 17:11:06 -0800
> >
> > > sparc64:allmodconfig fails to build with the following error.
> > >
> > > unrecognized e_machine 18 arch/sparc/vdso/vdso32/vclock_gettime.o
> > > arch/sparc/vdso/vdso32/vclock_gettime.o: failed
> > > make[2]: *** [arch/sparc/vdso/vdso32/vclock_gettime.o] Error 1
> > > make[2]: *** Deleting file 'arch/sparc/vdso/vdso32/vclock_gettime.o'
> > > make[2]: *** Waiting for unfinished jobs....
> > >
> > > The problem bisects to commit a3de7a72c517 ("kbuild: change
> > > *FLAGS_<basetarget>.o to take the path relative to $(obj)").
> > > Duplicate the x86 specific defines from this commit to the sparc
> > > vdso Makefile to fix the problem.
> > >
> > > Fixes: a3de7a72c517 ("kbuild: change *FLAGS_<basetarget>.o to take the path relative to $(obj)")
> > > Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > > Cc: Marc Zyngier <maz@xxxxxxxxxx>
> > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >
> > Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
>
>
> Yeah, I had submitted a fix a long time before.
>
> https://lore.kernel.org/patchwork/patch/1130469/
>
> I do not know why it was not picked up.

Why don't you just push it upstream yourself ?

> It is OK whether any patch is picked up
> as long as the build error is fixed.
Same here.

> (I think  CFLAGS_REMOVE_vdso32/vdso-note.o
> should be added too, though)
Hard to decide for someone not involved in vdso development.
It wasn't added for x86, and it compiles without, so I rather
left it alone.

Guenter