Re: [PATCH RFC] PCI: endpoint: Add NVMe endpoint function driver
From: Christoph Hellwig
Date: Mon Nov 11 2019 - 15:37:47 EST
On Mon, Nov 11, 2019 at 09:38:09AM -0800, Alan Mikhak wrote:
> A design goal is to not modify the Linux NVMe target driver
> at all.
As I told you before that is not a "goal" but a fundamental mistake and
against the design philosophy of all major Linux subsystems. Please fix
your series to move all command parsing to the code based on flags for
fabrics vs PCIe in the few places where they significantly differ.