Re: [PATCH 1/4] irq_work: Convert flags to atomic_t

[Frederic Weisbecker]

On Mon, Nov 11, 2019 at 09:00:58AM +0100, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <frederic@xxxxxxxxxx> wrote:
> 
> > We need to convert flags to atomic_t in order to later fix an ordering
> > issue on cmpxchg() failure. This will allow us to use atomic_fetch_or().
> > Also that clarify the nature of those flags.
> > 
> > Signed-off-by: Frederic Weisbecker <frederic@xxxxxxxxxx>
> > Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > ---
> >  include/linux/irq_work.h | 10 +++++++---
> >  kernel/irq_work.c        | 18 +++++++++---------
> >  kernel/printk/printk.c   |  2 +-
> >  3 files changed, 17 insertions(+), 13 deletions(-)
> 
> You missed the irq_work use in kernel/bpf/stackmap.c - see the fix below.
> 
> Thanks,
> 
> 	Ingo

Oh thanks. Strange that I haven't seen a 0-day warning about those.