Re: [PATCH] net: add missing semicolon in net_dev_template

From: Steven Rostedt
Date: Mon Nov 11 2019 - 18:12:32 EST


On Mon, 11 Nov 2019 22:17:53 +0800
Tony Lu <tonylu@xxxxxxxxxxxxxxxxx> wrote:

> This patch adds missing semicolon in the end of net_dev_template.
>
> Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
> Signed-off-by: Tony Lu <tonylu@xxxxxxxxxxxxxxxxx>
> ---
> include/trace/events/net.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/net.h b/include/trace/events/net.h
> index 2399073c3afc..3b28843652d2 100644
> --- a/include/trace/events/net.h
> +++ b/include/trace/events/net.h
> @@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
>
> TP_printk("dev=%s skbaddr=%p len=%u",
> __get_str(name), __entry->skbaddr, __entry->len)
> -)
> +);

Actually, we are thinking of making a sweeping patch set to remove all
these semicolons, as they are not needed, and would also allow more
flexible processing of the trace event macros.

-- Steve

>
> DEFINE_EVENT(net_dev_template, net_dev_queue,
>