Re: [PATCH v4 0/6] KVM: x86/vPMU: Efficiency optimization by reusing last created perf_event

[Paolo Bonzini]

On 12/11/19 07:08, Like Xu wrote:
> Hi Paolo,
> 
> On 2019/10/29 0:43, Peter Zijlstra wrote:
>> On Sun, Oct 27, 2019 at 06:52:37PM +0800, Like Xu wrote:
>>> For perf subsystem, please help review first two patches.
>>
>>> Like Xu (6):
>>> ÂÂ perf/core: Provide a kernel-internal interface to recalibrate event
>>> ÂÂÂÂ period
>>> ÂÂ perf/core: Provide a kernel-internal interface to pause perf_event
>>
>> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>>
> 
> Would you mind to revisit the following patches for upstream ?
> 
>>ÂÂÂ KVM: x86/vPMU: Rename pmu_ops callbacks from msr_idx to rdpmc_ecx
>>ÂÂÂ KVM: x86/vPMU: Introduce a new kvm_pmu_ops->msr_idx_to_pmc callback
>>ÂÂÂ KVM: x86/vPMU: Reuse perf_event to avoid unnecessary
>>ÂÂÂÂÂ pmc_reprogram_counter
>>ÂÂÂ KVM: x86/vPMU: Add lazy mechanism to release perf_event per vPMC

Queued, thanks.

Paolo

> For vPMU, please review two more patches as well:
> +
> https://lore.kernel.org/kvm/20191030164418.2957-1-like.xu@xxxxxxxxxxxxxxx/
> (kvm)
> +
> https://lore.kernel.org/lkml/20191105140955.22504-1-like.xu@xxxxxxxxxxxxxxx/
> (perf)
> 
> Thanks,
> Like Xu
>