Re: [PATCH 1/2] spi: dt-bindings: spi-controller: add wakeup-source and interrupts

From: Mark Brown
Date: Tue Nov 12 2019 - 07:03:12 EST


On Mon, Nov 11, 2019 at 09:54:10PM -0800, Dmitry Torokhov wrote:

> + interrupts:
> + items:
> + - description: main interrupt (attention) line.
> + - description: dedicated wakeup interrupt.
> + minItems: 1 # The wakeup interrupt is optional.
> + description:
> + Specifies interrupt lines a device is connected to. Typically a
> + device is wired to a single interrupt line that is used as
> + "attention" signal and also to wake up system when device is
> + set up as wakeup source. However on some systems a dedicated
> + wakeup line might be used.

> + interrupt-names:
> + items:
> + - const: irq
> + - const: wakeup
> + minItems: 1

How will this interact with a SPI device that defines interrupts at the
device level, possibly more than one of them? Especially if the device
has its own idea what the interrupts should be called.

Attachment: signature.asc
Description: PGP signature