Re: [patch V2 07/16] x86/ioperm: Move iobitmap data into a struct
From: Thomas Gleixner
Date: Tue Nov 12 2019 - 12:08:54 EST
On Tue, 12 Nov 2019, Andy Lutomirski wrote:
> On Mon, Nov 11, 2019 at 2:35 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > --- /dev/null
> > +++ b/arch/x86/include/asm/iobitmap.h
> > @@ -0,0 +1,15 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _ASM_X86_IOBITMAP_H
> > +#define _ASM_X86_IOBITMAP_H
> > +
> > +#include <asm/processor.h>
> > +
> > +struct io_bitmap {
> > + unsigned int io_bitmap_max;
> > + union {
> > + unsigned long bits[IO_BITMAP_LONGS];
> > + unsigned char bitmap_bytes[IO_BITMAP_BYTES];
> > + };
>
> Now that you have bytes and longs, can you rename io_bitmap_max so
> it's obvious which one it refers to?
Sure.