Re: [PATCH v6 1/2] loop: Report EOPNOTSUPP properly

From: Evan Green
Date: Tue Nov 12 2019 - 14:09:52 EST


On Tue, Nov 12, 2019 at 12:32 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Mon, Nov 11, 2019 at 10:50:29AM -0800, Evan Green wrote:
> > - if (cmd->ret < 0)
> > + if (cmd->ret == -EOPNOTSUPP)
> > + ret = BLK_STS_NOTSUPP;
> > + else if (cmd->ret < 0)
> > ret = BLK_STS_IOERR;
>
> This really should use errno_to_blk_status. Same for the other hunk.

Seems reasonable, I can switch to that.