Re: [PATCH] dt-bindings: watchdog: Convert stm32 watchdog bindings to json-schema

[Benjamin Gaignard]

Le jeu. 17 oct. 2019 Ã 15:31, Guenter Roeck <linux@xxxxxxxxxxxx> a Ãcrit :
>
> On 10/17/19 6:17 AM, Benjamin GAIGNARD wrote:
> >
> > On 10/17/19 3:06 PM, Alexandre Torgue wrote:
> >> Hi Benjamin
> >>
> >> On 10/17/19 2:41 PM, Benjamin Gaignard wrote:
> >>> Convert the STM32 watchdog binding to DT schema format using json-schema
> >>>
> >>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
> >>> ---
> >>>    .../devicetree/bindings/watchdog/st,stm32-iwdg.txt | 26 -----------
> >>>    .../bindings/watchdog/st,stm32-iwdg.yaml           | 54
> >>> ++++++++++++++++++++++
> >>>    2 files changed, 54 insertions(+), 26 deletions(-)
> >>>    delete mode 100644
> >>> Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> >>>    create mode 100644
> >>> Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
> >>>
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> >>> b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> >>> deleted file mode 100644
> >>> index d8f4430b0a13..000000000000
> >>> --- a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> >>> +++ /dev/null
> >>> @@ -1,26 +0,0 @@
> >>> -STM32 Independent WatchDoG (IWDG)
> >>> ----------------------------------
> >>> -
> >>> -Required properties:
> >>> -- compatible: Should be either:
> >>> -  - "st,stm32-iwdg"
> >>> -  - "st,stm32mp1-iwdg"
> >>> -- reg: Physical base address and length of the registers set for the
> >>> device
> >>> -- clocks: Reference to the clock entry lsi. Additional pclk clock entry
> >>> -  is required only for st,stm32mp1-iwdg.
> >>> -- clock-names: Name of the clocks used.
> >>> -  "lsi" for st,stm32-iwdg
> >>> -  "lsi", "pclk" for st,stm32mp1-iwdg
> >>> -
> >>> -Optional Properties:
> >>> -- timeout-sec: Watchdog timeout value in seconds.
> >>> -
> >>> -Example:
> >>> -
> >>> -iwdg: watchdog@40003000 {
> >>> -    compatible = "st,stm32-iwdg";
> >>> -    reg = <0x40003000 0x400>;
> >>> -    clocks = <&clk_lsi>;
> >>> -    clock-names = "lsi";
> >>> -    timeout-sec = <32>;
> >>> -};
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
> >>> b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
> >>> new file mode 100644
> >>> index 000000000000..edec96d53e6b
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
> >>> @@ -0,0 +1,54 @@
> >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >>> +%YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/watchdog/st,stm32-iwdg.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: STMicroelectronics STM32 Independent WatchDoG (IWDG) bindings
> >>> +
> >>> +maintainers:
> >>> +  - Yannick Fertre <yannick.fertre@xxxxxx>
> >>
> >> Yannick is still working on this driver ?
> >
> > That is a good question.
> >
> > Rob, can we use the STM32 dedicated mailing list address for this
> > mainteners field ?
> >
> > maintainers:
> >
> > - linux STM32 <linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> >
>
>
> I'd rather wonder who is going to maintain this secondary distributed
> maintainers list, but I guess that is a different question.
>

Gentle ping to reviewers on this patch.

Thanks,
Benjamin

> Guenter
>
> > Regards,
> >
> > Benjamin
> >
> >>
> >>> +
> >>> +allOf:
> >>> +  - $ref: "watchdog.yaml#"
> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    enum:
> >>> +      - st,stm32-iwdg
> >>> +      - st,stm32mp1-iwdg
> >>> +
> >>> +  reg:
> >>> +    maxItems: 1
> >>> +
> >>> +  clocks:
> >>> +    items:
> >>> +      - description: Low speed clock
> >>> +      - description: Optional peripheral clock
> >>> +    minItems: 1
> >>> +    maxItems: 2
> >>> +
> >>> +  clock-names:
> >>> +    items:
> >>> +      enums: [ lsi, pclk ]
> >>> +    minItems: 1
> >>> +    maxItems: 2
> >>> +
> >>> +required:
> >>> +  - compatible
> >>> +  - reg
> >>> +  - clocks
> >>> +  - clock-names
> >>> +
> >>> +examples:
> >>> +  - |
> >>> +    #include <dt-bindings/clock/stm32mp1-clks.h>
> >>> +    watchdog@5a002000 {
> >>> +      compatible = "st,stm32mp1-iwdg";
> >>> +      reg = <0x5a002000 0x400>;
> >>> +      clocks = <&rcc IWDG2>, <&rcc CK_LSI>;
> >>> +      clock-names = "pclk", "lsi";
> >>> +      timeout-sec = <32>;
> >>> +    };
> >>> +
> >>> +...
> >> >
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel