Re: [PATCH 3/5] iio: ping: add parallax ping sensors

From: Michal VokÃÄ
Date: Wed Nov 13 2019 - 06:09:48 EST


On 10. 11. 19 18:06, Jonathan Cameron wrote:
On Thu, 7 Nov 2019 14:00:47 +0100
Andreas Klinger <ak@xxxxxxxxxxxxx> wrote:
[snip]

+ *
+ * +---+ +------------------------+
+ * GPIO | | | |
+ * ping: --+ +------------+ +----------------
+ * ^ ^ ^ ^
+ * |<->| interrupt interrupt
+ * udelay(5) (ts_rising) (ts_falling)
+ * |<---------------------->|
+ * . pulse time measured
+ * . --> one round trip of ultra sonic waves
+ * . .
+ * ultra +-+ +-+ +-+ .
+ * sonic | | | | | | .
+ * burst: ---------+ +-+ +-+ +-----------------------------------------
+ * .
+ * ultra +-+ +-+ +-+
+ * sonic | | | | | |
+ * echo: ----------------------------------+ +-+ +-+ +----------------

Nice diagram ;)

Using the '+' characters at the edges and '-' characters for levels makes it
not easily readable in some cases. Especially for the short subsequent bursts.
What about this?

* GPIO ___ ________________________
* ping: __/ \____________/ \_________________
* ^ ^ ^ ^
* |<->| interrupt interrupt
* udelay(5) (ts_rising) (ts_falling)
* |<---------------------->|
* . pulse time measured
* . --> one round trip of ultra sonic waves
* . .
* ultra . .
* sonic _ _ _. .
* burst: ________/ \_/ \_/ \_________________________________________
* .
* ultra .
* sonic _ _ _.
* echo: _________________________________/ \_/ \_/ \_________________
*/

Michal