Re: [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed

From: Daniel Baluta
Date: Wed Nov 13 2019 - 07:36:03 EST


On Wed, 2019-11-13 at 12:15 +0000, Peng Fan wrote:
> Hi Daniel,
>
> > Subject: Re: [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed
> >
> >
> > On Wed, 2019-11-13 at 07:24 +0000, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > It not make sense to use writel, use relaxed variant.
> > >
> >
> > Hi Peng,
> >
> > Please explain why this change is needed.
>
> writel has a barrier, however that barrier is not needed,
> because device memory access is in order and clk driver
> has spin_lock or other lock to make sure write finished.
>

Make sure you add this in the commit message for v2 :).