Re: [Xen-devel] [PATCH 3/3] xen/mcelog: also allow building for 32-bit kernels

[JÃrgen GroÃ]

On 13.11.19 14:47, Jan Beulich wrote:
> On 13.11.2019 01:15, Boris Ostrovsky wrote:
> > On 11/11/19 9:46 AM, Jan Beulich wrote:
> > > There's no apparent reason why it can be used on 64-bit only.
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > >
> > > --- a/drivers/xen/Kconfig
> > > +++ b/drivers/xen/Kconfig
> > > @@ -285,7 +285,7 @@ config XEN_ACPI_PROCESSOR
> > >   
> > >   config XEN_MCE_LOG
> > >   	bool "Xen platform mcelog"
> > > -	depends on XEN_DOM0 && X86_64 && X86_MCE
> > > +	depends on XEN_DOM0 && X86 && X86_MCE
> >
> > Can we have X86_MCE without X86?
>
> I don't think we can. Is this a request to drop the middle
> operand altogether?

I think this would be reasonable. X86_64 was an additional dependency,
while X86 isn't.

With the X86 removed:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen