Re: [PATCH -v5 05/17] x86/ftrace: Use text_poke()

From: Steven Rostedt
Date: Wed Nov 13 2019 - 09:27:47 EST


On Wed, 13 Nov 2019 10:01:04 +0100
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > And that printk() never printed, even after running the ftracetests.
>
> Well, then wth did it do that set_all_modules_text_rw() nonsense?
> Because all I did was preserve that semantic.

Because the ftracetests obviously is missing a check :-p

It never printed when running those tests, but when I did a simple:

# trace-cmd start -p function
# modprobe <some-module>

The printk appeared.

Yeah, let's keep it this way, but still needs a comment.

-- Steve