Re: [PATCH] firmware_class: make firmware caching configurable

From: Luis Chamberlain
Date: Wed Nov 13 2019 - 17:13:23 EST


On Thu, Nov 14, 2019 at 05:50:31AM +0800, Greg Kroah-Hartman wrote:
> On Wed, Nov 13, 2019 at 01:01:13PM -0800, Mark Salyzyn wrote:
> > +config FW_CACHE
> > + bool "Enable firmware caching during suspend"
> > + depends on PM_SLEEP
> > + default y
> And finally, 'default y' is only a good idea if your machine can not
> boot without the option. I don't think that's the case here, correct?

default y if PM_SLEEP

Would try to enable this if PM_SLEEP was disabled. So the depends on
will force this on for all systems by default if PM_SLEEP is enabled,
which is what how this works today.

We enable this feature today by default if you have PM_SLEEP.

Luis