Re: [PATCH 5/5] clk: sprd: add clocks support for SC9863A

From: Stephen Boyd
Date: Wed Nov 13 2019 - 17:20:02 EST

Next message: Rafael J. Wysocki: "Re: [PATCH RFC 3/3] cpuidle: Use the latency to call find_deepest_idle_state"
Previous message: Stephen Boyd: "Re: [PATCH 1/5] clk: sprd: add gate for pll clocks"
Next in thread: Chunyan Zhang: "Re: [PATCH 5/5] clk: sprd: add clocks support for SC9863A"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Quoting Chunyan Zhang (2019-10-25 04:13:38)
>
> Add the list of clocks for the Unisoc SC9863A, alone with clock

s/alone/along/?

> initialization.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
> diff --git a/drivers/clk/sprd/sc9863a-clk.c b/drivers/clk/sprd/sc9863a-clk.c
> new file mode 100644
> index 000000000000..5369db1090f0
> --- /dev/null
> +++ b/drivers/clk/sprd/sc9863a-clk.c
> @@ -0,0 +1,1711 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Unisoc SC9863A clock driver
> + *
> + * Copyright (C) 2019 Unisoc, Inc.
> + * Author: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
> + */
> +
> +#include <linux/clk-provider.h>
> +#include <linux/err.h>
> +#include <linux/io.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +#include <linux/slab.h>
> +
> +#include <dt-bindings/clock/sprd,sc9863a-clk.h>
> +
> +#include "common.h"
> +#include "composite.h"
> +#include "div.h"
> +#include "gate.h"
> +#include "mux.h"
> +#include "pll.h"
> +
> +SPRD_PLL_SC_GATE_CLK(mpll0_gate, "mpll0-gate", "ext-26m", 0x94,
> + 0x1000, BIT(0), CLK_IGNORE_UNUSED, 0, 240);
> +SPRD_PLL_SC_GATE_CLK(dpll0_gate, "dpll0-gate", "ext-26m", 0x98,
> + 0x1000, BIT(0), CLK_IGNORE_UNUSED, 0, 240);
> +SPRD_PLL_SC_GATE_CLK(lpll_gate, "lpll-gate", "ext-26m", 0x9c,
> + 0x1000, BIT(0), CLK_IGNORE_UNUSED, 0, 240);
> +SPRD_PLL_SC_GATE_CLK(gpll_gate, "gpll-gate", "ext-26m", 0xa8,
> + 0x1000, BIT(0), CLK_IGNORE_UNUSED, 0, 240);
> +SPRD_PLL_SC_GATE_CLK(dpll1_gate, "dpll1-gate", "ext-26m", 0x1dc,
> + 0x1000, BIT(0), CLK_IGNORE_UNUSED, 0, 240);
> +SPRD_PLL_SC_GATE_CLK(mpll1_gate, "mpll1-gate", "ext-26m", 0x1e0,
> + 0x1000, BIT(0), CLK_IGNORE_UNUSED, 0, 240);
> +SPRD_PLL_SC_GATE_CLK(mpll2_gate, "mpll2-gate", "ext-26m", 0x1e4,
> + 0x1000, BIT(0), CLK_IGNORE_UNUSED, 0, 240);
> +SPRD_PLL_SC_GATE_CLK(isppll_gate, "isppll-gate", "ext-26m", 0x1e8,
> + 0x1000, BIT(0), CLK_IGNORE_UNUSED, 0, 240);
> +
> +static struct sprd_clk_common *sc9863a_pmu_gate_clks[] = {
> + /* address base is 0x402b0000 */
> + &mpll0_gate.common,
> + &dpll0_gate.common,
> + &lpll_gate.common,
> + &gpll_gate.common,
> + &dpll1_gate.common,
> + &mpll1_gate.common,
> + &mpll2_gate.common,
> + &isppll_gate.common,
> +};
> +
> +static struct clk_hw_onecell_data sc9863a_pmu_gate_hws = {
> + .hws = {
> + [CLK_MPLL0_GATE] = &mpll0_gate.common.hw,
> + [CLK_DPLL0_GATE] = &dpll0_gate.common.hw,
> + [CLK_LPLL_GATE] = &lpll_gate.common.hw,
> + [CLK_GPLL_GATE] = &gpll_gate.common.hw,
> + [CLK_DPLL1_GATE] = &dpll1_gate.common.hw,
> + [CLK_MPLL1_GATE] = &mpll1_gate.common.hw,
> + [CLK_MPLL2_GATE] = &mpll2_gate.common.hw,
> + [CLK_ISPPLL_GATE] = &isppll_gate.common.hw,
> + },
> + .num = CLK_PMU_APB_NUM,
> +};
> +
> +static const struct sprd_clk_desc sc9863a_pmu_gate_desc = {
> + .clk_clks = sc9863a_pmu_gate_clks,
> + .num_clk_clks = ARRAY_SIZE(sc9863a_pmu_gate_clks),
> + .hw_clks = &sc9863a_pmu_gate_hws,
> +};
> +
> +static const u64 itable[5] = {4, 1000000000, 1200000000,
> + 1400000000, 1600000000};
> +
> +static const struct clk_bit_field f_twpll[PLL_FACT_MAX] = {
> + { .shift = 95, .width = 1 }, /* lock_done */
> + { .shift = 0, .width = 1 }, /* div_s */
> + { .shift = 1, .width = 1 }, /* mod_en */
> + { .shift = 2, .width = 1 }, /* sdm_en */
> + { .shift = 0, .width = 0 }, /* refin */
> + { .shift = 3, .width = 3 }, /* ibias */
> + { .shift = 8, .width = 11 }, /* n */
> + { .shift = 55, .width = 7 }, /* nint */
> + { .shift = 32, .width = 23}, /* kint */
> + { .shift = 0, .width = 0 }, /* prediv */
> + { .shift = 0, .width = 0 }, /* postdiv */
> +};
> +static SPRD_PLL_WITH_ITABLE_1K(twpll_clk, "twpll", "ext-26m", 0x4,
> + 3, itable, f_twpll, 240);
> +static CLK_FIXED_FACTOR(twpll_768m, "twpll-768m", "twpll", 2, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_384m, "twpll-384m", "twpll", 4, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_192m, "twpll-192m", "twpll", 8, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_96m, "twpll-96m", "twpll", 16, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_48m, "twpll-48m", "twpll", 32, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_24m, "twpll-24m", "twpll", 64, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_12m, "twpll-12m", "twpll", 128, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_512m, "twpll-512m", "twpll", 3, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_256m, "twpll-256m", "twpll", 6, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_128m, "twpll-128m", "twpll", 12, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_64m, "twpll-64m", "twpll", 24, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_307m2, "twpll-307m2", "twpll", 5, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_219m4, "twpll-219m4", "twpll", 7, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_170m6, "twpll-170m6", "twpll", 9, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_153m6, "twpll-153m6", "twpll", 10, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_76m8, "twpll-76m8", "twpll", 20, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_51m2, "twpll-51m2", "twpll", 30, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_38m4, "twpll-38m4", "twpll", 40, 1, 0);
> +static CLK_FIXED_FACTOR(twpll_19m2, "twpll-19m2", "twpll", 80, 1, 0);
> +
> +static const struct clk_bit_field f_lpll[PLL_FACT_MAX] = {
> + { .shift = 95, .width = 1 }, /* lock_done */
> + { .shift = 0, .width = 1 }, /* div_s */
> + { .shift = 1, .width = 1 }, /* mod_en */
> + { .shift = 2, .width = 1 }, /* sdm_en */
> + { .shift = 0, .width = 0 }, /* refin */
> + { .shift = 6, .width = 2 }, /* ibias */
> + { .shift = 8, .width = 11 }, /* n */
> + { .shift = 55, .width = 7 }, /* nint */
> + { .shift = 32, .width = 23}, /* kint */
> + { .shift = 0, .width = 0 }, /* prediv */
> + { .shift = 0, .width = 0 }, /* postdiv */
> +};
> +static SPRD_PLL_WITH_ITABLE_1K(lpll_clk, "lpll", "lpll-gate", 0x20,
> + 3, itable, f_lpll, 240);
> +static CLK_FIXED_FACTOR(lpll_409m6, "lpll-409m6", "lpll", 3, 1, 0);
> +static CLK_FIXED_FACTOR(lpll_245m76, "lpll-245m76", "lpll", 5, 1, 0);
> +
> +static const struct clk_bit_field f_gpll[PLL_FACT_MAX] = {
> + { .shift = 95, .width = 1 }, /* lock_done */
> + { .shift = 0, .width = 1 }, /* div_s */
> + { .shift = 1, .width = 1 }, /* mod_en */
> + { .shift = 2, .width = 1 }, /* sdm_en */
> + { .shift = 0, .width = 0 }, /* refin */
> + { .shift = 6, .width = 2 }, /* ibias */
> + { .shift = 8, .width = 11 }, /* n */
> + { .shift = 55, .width = 7 }, /* nint */
> + { .shift = 32, .width = 23}, /* kint */
> + { .shift = 0, .width = 0 }, /* prediv */
> + { .shift = 80, .width = 1 }, /* postdiv */
> +};
> +static SPRD_PLL_WITH_ITABLE_K_FVCO(gpll_clk, "gpll", "gpll-gate", 0x38,
> + 3, itable, f_gpll, 240,
> + 1000, 1000, 1, 400000000);
> +
> +#define f_isppll f_gpll

Why redefine? Please use the actual variable name where it is used.

> +static SPRD_PLL_WITH_ITABLE_1K(isppll_clk, "isppll", "isppll-gate", 0x50,
> + 3, itable, f_isppll, 240);
> +static CLK_FIXED_FACTOR(isppll_468m, "isppll-468m", "isppll", 2, 1, 0);
> +
> +static struct sprd_clk_common *sc9863a_pll_clks[] = {
> + /* address base is 0x40353000 */
> + &twpll_clk.common,
> + &lpll_clk.common,
> + &gpll_clk.common,
> + &isppll_clk.common,
> +};
> +
> +static struct clk_hw_onecell_data sc9863a_pll_hws = {
> + .hws = {
> + [CLK_TWPLL] = &twpll_clk.common.hw,
> + [CLK_TWPLL_768M] = &twpll_768m.hw,
> + [CLK_TWPLL_384M] = &twpll_384m.hw,
> + [CLK_TWPLL_192M] = &twpll_192m.hw,
> + [CLK_TWPLL_96M] = &twpll_96m.hw,
> + [CLK_TWPLL_48M] = &twpll_48m.hw,
> + [CLK_TWPLL_24M] = &twpll_24m.hw,
> + [CLK_TWPLL_12M] = &twpll_12m.hw,
> + [CLK_TWPLL_512M] = &twpll_512m.hw,
> + [CLK_TWPLL_256M] = &twpll_256m.hw,
> + [CLK_TWPLL_128M] = &twpll_128m.hw,
> + [CLK_TWPLL_64M] = &twpll_64m.hw,
> + [CLK_TWPLL_307M2] = &twpll_307m2.hw,
> + [CLK_TWPLL_219M4] = &twpll_219m4.hw,
> + [CLK_TWPLL_170M6] = &twpll_170m6.hw,
> + [CLK_TWPLL_153M6] = &twpll_153m6.hw,
> + [CLK_TWPLL_76M8] = &twpll_76m8.hw,
> + [CLK_TWPLL_51M2] = &twpll_51m2.hw,
> + [CLK_TWPLL_38M4] = &twpll_38m4.hw,
> + [CLK_TWPLL_19M2] = &twpll_19m2.hw,
> + [CLK_LPLL] = &lpll_clk.common.hw,
> + [CLK_LPLL_409M6] = &lpll_409m6.hw,
> + [CLK_LPLL_245M76] = &lpll_245m76.hw,
> + [CLK_GPLL] = &gpll_clk.common.hw,
> + [CLK_ISPPLL] = &isppll_clk.common.hw,
> + [CLK_ISPPLL_468M] = &isppll_468m.hw,
> +
> + },
> + .num = CLK_ANLG_PHY_G1_NUM,
> +};
> +
> +static const struct sprd_clk_desc sc9863a_pll_desc = {
> + .clk_clks = sc9863a_pll_clks,
> + .num_clk_clks = ARRAY_SIZE(sc9863a_pll_clks),
> + .hw_clks = &sc9863a_pll_hws,
> +};
> +
> +#define f_mpll f_gpll

Same comment.

> +static const u64 itable_mpll[6] = {5, 1000000000, 1200000000, 1400000000,
> + 1600000000, 1800000000};
> +static SPRD_PLL_WITH_ITABLE_K_FVCO(mpll0_clk, "mpll0", "mpll0-gate", 0x0,
> + 3, itable_mpll, f_mpll, 240,
> + 1000, 1000, 1, 1000000000);
> +static SPRD_PLL_WITH_ITABLE_K_FVCO(mpll1_clk, "mpll1", "mpll1-gate", 0x18,
> + 3, itable_mpll, f_mpll, 240,
> + 1000, 1000, 1, 1000000000);
> +static SPRD_PLL_WITH_ITABLE_K_FVCO(mpll2_clk, "mpll2", "mpll2-gate", 0x30,
> + 3, itable_mpll, f_mpll, 240,
> + 1000, 1000, 1, 1000000000);
> +static CLK_FIXED_FACTOR(mpll2_675m, "mpll2-675m", "mpll2", 2, 1, 0);
> +
> +static struct sprd_clk_common *sc9863a_mpll_clks[] = {
> + /* address base is 0x40359000 */
> + &mpll0_clk.common,
> + &mpll1_clk.common,
> + &mpll2_clk.common,
> +};
> +
> +static struct clk_hw_onecell_data sc9863a_mpll_hws = {
> + .hws = {
> + [CLK_MPLL0] = &mpll0_clk.common.hw,
> + [CLK_MPLL1] = &mpll1_clk.common.hw,
> + [CLK_MPLL2] = &mpll2_clk.common.hw,
> + [CLK_MPLL2_675M] = &mpll2_675m.hw,
> +
> + },
> + .num = CLK_ANLG_PHY_G4_NUM,
> +};
> +
> +static const struct sprd_clk_desc sc9863a_mpll_desc = {
> + .clk_clks = sc9863a_mpll_clks,
> + .num_clk_clks = ARRAY_SIZE(sc9863a_mpll_clks),
> + .hw_clks = &sc9863a_mpll_hws,
> +};
> +
> +static SPRD_SC_GATE_CLK(audio_gate, "audio-gate", "ext-26m", 0x4,
> + 0x1000, BIT(8), CLK_IGNORE_UNUSED, 0);
> +
> +#define f_rpll f_lpll

Same comment.

> +static SPRD_PLL_WITH_ITABLE_1K(rpll_clk, "rpll", "ext-26m", 0x10,
> + 3, itable, f_rpll, 240);
> +
> +static CLK_FIXED_FACTOR(rpll_390m, "rpll-390m", "rpll", 2, 1, 0);
> +static CLK_FIXED_FACTOR(rpll_260m, "rpll-260m", "rpll", 3, 1, 0);
> +static CLK_FIXED_FACTOR(rpll_195m, "rpll-195m", "rpll", 4, 1, 0);
> +static CLK_FIXED_FACTOR(rpll_26m, "rpll-26m", "rpll", 30, 1, 0);
> +
> +static struct sprd_clk_common *sc9863a_rpll_clks[] = {
> + /* address base is 0x4035c000 */
> + &audio_gate.common,
> + &rpll_clk.common,
> +};
> +
> +static struct clk_hw_onecell_data sc9863a_rpll_hws = {
> + .hws = {
> + [CLK_AUDIO_GATE] = &audio_gate.common.hw,
> + [CLK_RPLL] = &rpll_clk.common.hw,
> + [CLK_RPLL_390M] = &rpll_390m.hw,
> + [CLK_RPLL_260M] = &rpll_260m.hw,
> + [CLK_RPLL_195M] = &rpll_195m.hw,
> + [CLK_RPLL_26M] = &rpll_26m.hw,
> + },
> + .num = CLK_ANLG_PHY_G5_NUM,
> +};
> +
> +static const struct sprd_clk_desc sc9863a_rpll_desc = {
> + .clk_clks = sc9863a_rpll_clks,
> + .num_clk_clks = ARRAY_SIZE(sc9863a_rpll_clks),
> + .hw_clks = &sc9863a_rpll_hws,
> +};
> +
> +#define f_dpll f_lpll

Same comment.

> +static const u64 itable_dpll[5] = {4, 1211000000, 1320000000, 1570000000,
> + 1866000000};
> +static SPRD_PLL_WITH_ITABLE_1K(dpll0_clk, "dpll0", "dpll0-gate", 0x0,
> + 3, itable_dpll, f_dpll, 240);
> +static SPRD_PLL_WITH_ITABLE_1K(dpll1_clk, "dpll1", "dpll1-gate", 0x18,
> + 3, itable_dpll, f_dpll, 240);
> +
> +static CLK_FIXED_FACTOR(dpll0_933m, "dpll0-933m", "dpll0", 2, 1, 0);
> +static CLK_FIXED_FACTOR(dpll0_622m3, "dpll0-622m3", "dpll0", 3, 1, 0);
> +static CLK_FIXED_FACTOR(dpll1_400m, "dpll1-400m", "dpll1", 4, 1, 0);
> +static CLK_FIXED_FACTOR(dpll1_266m7, "dpll1-266m7", "dpll1", 6, 1, 0);
> +static CLK_FIXED_FACTOR(dpll1_123m1, "dpll1-123m1", "dpll1", 13, 1, 0);
> +static CLK_FIXED_FACTOR(dpll1_50m, "dpll1-50m", "dpll1", 32, 1, 0);
> +
> +static struct sprd_clk_common *sc9863a_dpll_clks[] = {
[...]
> +static SPRD_COMP_CLK(core0_clk, "core0-clk", core_parents, 0xa20,
> + 0, 3, 8, 3, 0);
> +static SPRD_COMP_CLK(core1_clk, "core1-clk", core_parents, 0xa24,
> + 0, 3, 8, 3, 0);
> +static SPRD_COMP_CLK(core2_clk, "core2-clk", core_parents, 0xa28,
> + 0, 3, 8, 3, 0);
> +static SPRD_COMP_CLK(core3_clk, "core3-clk", core_parents, 0xa2c,
> + 0, 3, 8, 3, 0);
> +static SPRD_COMP_CLK(core4_clk, "core4-clk", core_parents, 0xa30,
> + 0, 3, 8, 3, 0);
> +static SPRD_COMP_CLK(core5_clk, "core5-clk", core_parents, 0xa34,
> + 0, 3, 8, 3, 0);
> +static SPRD_COMP_CLK(core6_clk, "core6-clk", core_parents, 0xa38,
> + 0, 3, 8, 3, 0);
> +static SPRD_COMP_CLK(core7_clk, "core7-clk", core_parents, 0xa3c,
> + 0, 3, 8, 3, 0);
> +static SPRD_COMP_CLK(scu_clk, "scu-clk", core_parents, 0xa40,
> + 0, 3, 8, 3, 0);
> +static SPRD_DIV_CLK(ace_clk, "ace-clk", "scu-clk", 0xa44,
> + 8, 3, 0);
> +static SPRD_DIV_CLK(axi_periph_clk, "axi-periph-clk", "scu-clk", 0xa48,
> + 8, 3, 0);
> +static SPRD_DIV_CLK(axi_acp_clk, "axi-acp-clk", "scu-clk", 0xa4c,
> + 8, 3, 0);
> +
> +static const char * const atb_parents[] = { "ext-26m", "twpll-384m",
> + "twpll-512m", "mpll2" };
> +static SPRD_COMP_CLK(atb_clk, "atb-clk", atb_parents, 0xa50,
> + 0, 2, 8, 3, 0);
> +static SPRD_DIV_CLK(debug_apb_clk, "debug-apb-clk", "atb-clk", 0xa54,
> + 8, 3, 0);
> +
> +static const char * const gic_parents[] = { "ext-26m", "twpll-153m6",
> + "twpll-384m", "twpll-512m" };

Can you use the new way of specifying clk parents instead of using these
big string lists? That will hopefully cut down on the size of this code
by reducing all these string lists.

> +static SPRD_COMP_CLK(gic_clk, "gic-clk", gic_parents, 0xa58,
> + 0, 2, 8, 3, 0);
> +static SPRD_COMP_CLK(periph_clk, "periph-clk", gic_parents, 0xa5c,
> + 0, 2, 8, 3, 0);
> +
> +static struct sprd_clk_common *sc9863a_aon_clks[] = {
> + /* address base is 0x402d0000 */
> + &emc_clk.common,
> + &aon_apb.common,
> + &adi_clk.common,
> + &aux0_clk.common,
> + &aux1_clk.common,
> + &aux2_clk.common,
> + &probe_clk.common,
> + &pwm0_clk.common,
> + &pwm1_clk.common,
> + &pwm2_clk.common,
> + &aon_thm_clk.common,
> + &audif_clk.common,
> + &cpu_dap_clk.common,
> + &cpu_ts_clk.common,
> + &djtag_tck_clk.common,
> + &emc_ref_clk.common,
> + &cssys_clk.common,
> + &aon_pmu_clk.common,
> + &pmu_26m_clk.common,
> + &aon_tmr_clk.common,
> + &power_cpu_clk.common,
> + &ap_axi.common,
> + &sdio0_2x.common,
> + &sdio1_2x.common,
> + &sdio2_2x.common,
> + &emmc_2x.common,
> + &dpu_clk.common,
> + &dpu_dpi.common,
> + &otg_ref_clk.common,
> + &sdphy_apb_clk.common,
> + &alg_io_apb_clk.common,
> + &gpu_core.common,
> + &gpu_soc.common,
> + &mm_emc.common,
> + &mm_ahb.common,
> + &bpc_clk.common,
> + &dcam_if_clk.common,
> + &isp_clk.common,
> + &jpg_clk.common,
> + &cpp_clk.common,
> + &sensor0_clk.common,
> + &sensor1_clk.common,
> + &sensor2_clk.common,
> + &mm_vemc.common,
> + &mm_vahb.common,
> + &clk_vsp.common,
> + &core0_clk.common,
> + &core1_clk.common,
> + &core2_clk.common,
> + &core3_clk.common,
> + &core4_clk.common,
> + &core5_clk.common,
> + &core6_clk.common,
> + &core7_clk.common,
> + &scu_clk.common,
> + &ace_clk.common,
> + &axi_periph_clk.common,
> + &axi_acp_clk.common,
> + &atb_clk.common,
> + &debug_apb_clk.common,
> + &gic_clk.common,
> + &periph_clk.common,
> +};
> +
> +static struct clk_hw_onecell_data sc9863a_aon_clk_hws = {
> + .hws = {
> + [CLK_13M] = &clk_13m.hw,
> + [CLK_6M5] = &clk_6m5.hw,
> + [CLK_4M3] = &clk_4m3.hw,
> + [CLK_2M] = &clk_2m.hw,
> + [CLK_250K] = &clk_250k.hw,
> + [CLK_RCO_25M] = &rco_25m.hw,
> + [CLK_RCO_4M] = &rco_4m.hw,
> + [CLK_RCO_2M] = &rco_2m.hw,
> + [CLK_EMC] = &emc_clk.common.hw,
> + [CLK_AON_APB] = &aon_apb.common.hw,
> + [CLK_ADI] = &adi_clk.common.hw,
> + [CLK_AUX0] = &aux0_clk.common.hw,
> + [CLK_AUX1] = &aux1_clk.common.hw,
> + [CLK_AUX2] = &aux2_clk.common.hw,
> + [CLK_PROBE] = &probe_clk.common.hw,
> + [CLK_PWM0] = &pwm0_clk.common.hw,
> + [CLK_PWM1] = &pwm1_clk.common.hw,
> + [CLK_PWM2] = &pwm2_clk.common.hw,
> + [CLK_AON_THM] = &aon_thm_clk.common.hw,
> + [CLK_AUDIF] = &audif_clk.common.hw,
> + [CLK_CPU_DAP] = &cpu_dap_clk.common.hw,
> + [CLK_CPU_TS] = &cpu_ts_clk.common.hw,
> + [CLK_DJTAG_TCK] = &djtag_tck_clk.common.hw,
> + [CLK_EMC_REF] = &emc_ref_clk.common.hw,
> + [CLK_CSSYS] = &cssys_clk.common.hw,
> + [CLK_AON_PMU] = &aon_pmu_clk.common.hw,
> + [CLK_PMU_26M] = &pmu_26m_clk.common.hw,
> + [CLK_AON_TMR] = &aon_tmr_clk.common.hw,
> + [CLK_POWER_CPU] = &power_cpu_clk.common.hw,
> + [CLK_AP_AXI] = &ap_axi.common.hw,
> + [CLK_SDIO0_2X] = &sdio0_2x.common.hw,
> + [CLK_SDIO1_2X] = &sdio1_2x.common.hw,
> + [CLK_SDIO2_2X] = &sdio2_2x.common.hw,
> + [CLK_EMMC_2X] = &emmc_2x.common.hw,
> + [CLK_DPU] = &dpu_clk.common.hw,
> + [CLK_DPU_DPI] = &dpu_dpi.common.hw,
> + [CLK_OTG_REF] = &otg_ref_clk.common.hw,
> + [CLK_SDPHY_APB] = &sdphy_apb_clk.common.hw,
> + [CLK_ALG_IO_APB] = &alg_io_apb_clk.common.hw,
> + [CLK_GPU_CORE] = &gpu_core.common.hw,
> + [CLK_GPU_SOC] = &gpu_soc.common.hw,
> + [CLK_MM_EMC] = &mm_emc.common.hw,
> + [CLK_MM_AHB] = &mm_ahb.common.hw,
> + [CLK_BPC] = &bpc_clk.common.hw,
> + [CLK_DCAM_IF] = &dcam_if_clk.common.hw,
> + [CLK_ISP] = &isp_clk.common.hw,
> + [CLK_JPG] = &jpg_clk.common.hw,
> + [CLK_CPP] = &cpp_clk.common.hw,
> + [CLK_SENSOR0] = &sensor0_clk.common.hw,
> + [CLK_SENSOR1] = &sensor1_clk.common.hw,
> + [CLK_SENSOR2] = &sensor2_clk.common.hw,
> + [CLK_MM_VEMC] = &mm_vemc.common.hw,
> + [CLK_MM_VAHB] = &mm_vahb.common.hw,
> + [CLK_VSP] = &clk_vsp.common.hw,
> + [CLK_CORE0] = &core0_clk.common.hw,
> + [CLK_CORE1] = &core1_clk.common.hw,
> + [CLK_CORE2] = &core2_clk.common.hw,
> + [CLK_CORE3] = &core3_clk.common.hw,
> + [CLK_CORE4] = &core4_clk.common.hw,
> + [CLK_CORE5] = &core5_clk.common.hw,
> + [CLK_CORE6] = &core6_clk.common.hw,
> + [CLK_CORE7] = &core7_clk.common.hw,
> + [CLK_SCU] = &scu_clk.common.hw,
> + [CLK_ACE] = &ace_clk.common.hw,
> + [CLK_AXI_PERIPH] = &axi_periph_clk.common.hw,
> + [CLK_AXI_ACP] = &axi_acp_clk.common.hw,
> + [CLK_ATB] = &atb_clk.common.hw,
> + [CLK_DEBUG_APB] = &debug_apb_clk.common.hw,
> + [CLK_GIC] = &gic_clk.common.hw,
> + [CLK_PERIPH] = &periph_clk.common.hw,
> + },
> + .num = CLK_AON_CLK_NUM,
> +};
> +
> +static const struct sprd_clk_desc sc9863a_aon_clk_desc = {
> + .clk_clks = sc9863a_aon_clks,
> + .num_clk_clks = ARRAY_SIZE(sc9863a_aon_clks),
> + .hw_clks = &sc9863a_aon_clk_hws,
> +};
> +
> +static SPRD_SC_GATE_CLK(otg_eb, "otg-eb", "ap-axi", 0x0, 0x1000,
> + BIT(4), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(dma_eb, "dma-eb", "ap-axi", 0x0, 0x1000,
> + BIT(5), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(ce_eb, "ce-eb", "ap-axi", 0x0, 0x1000,
> + BIT(6), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(nandc_eb, "nandc-eb", "ap-axi", 0x0, 0x1000,
> + BIT(7), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(sdio0_eb, "sdio0-eb", "ap-axi", 0x0, 0x1000,
> + BIT(8), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(sdio1_eb, "sdio1-eb", "ap-axi", 0x0, 0x1000,
> + BIT(9), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(sdio2_eb, "sdio2-eb", "ap-axi", 0x0, 0x1000,
> + BIT(10), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(emmc_eb, "emmc-eb", "ap-axi", 0x0, 0x1000,
> + BIT(11), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(emmc_32k_eb, "emmc-32k-eb", "ap-axi", 0x0, 0x1000,
> + BIT(27), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(sdio0_32k_eb, "sdio0-32k-eb", "ap-axi", 0x0, 0x1000,
> + BIT(28), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(sdio1_32k_eb, "sdio1-32k-eb", "ap-axi", 0x0, 0x1000,
> + BIT(29), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(sdio2_32k_eb, "sdio2-32k-eb", "ap-axi", 0x0, 0x1000,
> + BIT(30), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(nandc_26m_eb, "nandc-26m-eb", "ap-axi", 0x0, 0x1000,
> + BIT(31), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(dma_eb2, "dma-eb2", "ap-axi", 0x18, 0x1000,
> + BIT(0), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(ce_eb2, "ce-eb2", "ap-axi", 0x18, 0x1000,
> + BIT(1), CLK_IGNORE_UNUSED, 0);
> +
> +static struct sprd_clk_common *sc9863a_apahb_gate_clks[] = {
> + /* address base is 0x20e00000 */
> + &otg_eb.common,
> + &dma_eb.common,
> + &ce_eb.common,
> + &nandc_eb.common,
> + &sdio0_eb.common,
> + &sdio1_eb.common,
> + &sdio2_eb.common,
> + &emmc_eb.common,
> + &emmc_32k_eb.common,
> + &sdio0_32k_eb.common,
> + &sdio1_32k_eb.common,
> + &sdio2_32k_eb.common,
> + &nandc_26m_eb.common,
> + &dma_eb2.common,
> + &ce_eb2.common,
> +};
> +
> +static struct clk_hw_onecell_data sc9863a_apahb_gate_hws = {
> + .hws = {
> + [CLK_OTG_EB] = &otg_eb.common.hw,
> + [CLK_DMA_EB] = &dma_eb.common.hw,
> + [CLK_CE_EB] = &ce_eb.common.hw,
> + [CLK_NANDC_EB] = &nandc_eb.common.hw,
> + [CLK_SDIO0_EB] = &sdio0_eb.common.hw,
> + [CLK_SDIO1_EB] = &sdio1_eb.common.hw,
> + [CLK_SDIO2_EB] = &sdio2_eb.common.hw,
> + [CLK_EMMC_EB] = &emmc_eb.common.hw,
> + [CLK_EMMC_32K_EB] = &emmc_32k_eb.common.hw,
> + [CLK_SDIO0_32K_EB] = &sdio0_32k_eb.common.hw,
> + [CLK_SDIO1_32K_EB] = &sdio1_32k_eb.common.hw,
> + [CLK_SDIO2_32K_EB] = &sdio2_32k_eb.common.hw,
> + [CLK_NANDC_26M_EB] = &nandc_26m_eb.common.hw,
> + [CLK_DMA_EB2] = &dma_eb2.common.hw,
> + [CLK_CE_EB2] = &ce_eb2.common.hw,
> + },
> + .num = CLK_AP_AHB_GATE_NUM,
> +};
> +
> +static const struct sprd_clk_desc sc9863a_apahb_gate_desc = {
> + .clk_clks = sc9863a_apahb_gate_clks,
> + .num_clk_clks = ARRAY_SIZE(sc9863a_apahb_gate_clks),
> + .hw_clks = &sc9863a_apahb_gate_hws,
> +};
> +
> +/* aon gate clocks */
> +static SPRD_SC_GATE_CLK(adc_eb, "adc-eb", "aon-apb", 0x0,
> + 0x1000, BIT(0), CLK_IGNORE_UNUSED, 0);

There's a lot of CLK_IGNORE_UNUSED. Why? Can you please add a comment in
the code about why we need this flag or remove the flag?

> +static SPRD_SC_GATE_CLK(fm_eb, "fm-eb", "aon-apb", 0x0,
> + 0x1000, BIT(1), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(tpc_eb, "tpc-eb", "aon-apb", 0x0,
> + 0x1000, BIT(2), CLK_IGNORE_UNUSED, 0);
> +static SPRD_SC_GATE_CLK(gpio_eb, "gpio-eb", "aon-apb", 0x0,
> + 0x1000, BIT(3), CLK_IGNORE_UNUSED, 0);
[...]
> +
> +static const struct sprd_clk_desc sc9863a_apapb_gate_desc = {
> + .clk_clks = sc9863a_apapb_gate,
> + .num_clk_clks = ARRAY_SIZE(sc9863a_apapb_gate),
> + .hw_clks = &sc9863a_apapb_gate_hws,
> +};
> +
> +static const struct of_device_id sprd_sc9863a_clk_ids[] = {
> + { .compatible = "sprd,sc9863a-ap-clk", /* 0x21500000 */

What are the comments? Register addresses?

> + .data = &sc9863a_ap_clk_desc },
> + { .compatible = "sprd,sc9863a-pmu-gate", /* 0x402b0000 */
> + .data = &sc9863a_pmu_gate_desc },
> + { .compatible = "sprd,sc9863a-pll", /* 0x40353000 */
> + .data = &sc9863a_pll_desc },
> + { .compatible = "sprd,sc9863a-mpll", /* 0x40359000 */
> + .data = &sc9863a_mpll_desc },
> + { .compatible = "sprd,sc9863a-rpll", /* 0x4035c000 */
> + .data = &sc9863a_rpll_desc },
> + { .compatible = "sprd,sc9863a-dpll", /* 0x40363000 */
> + .data = &sc9863a_dpll_desc },
> + { .compatible = "sprd,sc9863a-aon-clk", /* 0x402d0000 */
> + .data = &sc9863a_aon_clk_desc },
> + { .compatible = "sprd,sc9863a-apahb-gate", /* 0x20e00000 */
> + .data = &sc9863a_apahb_gate_desc },
> + { .compatible = "sprd,sc9863a-aonapb-gate", /* 0x402e0000 */
> + .data = &sc9863a_aonapb_gate_desc },
> + { .compatible = "sprd,sc9863a-mm-gate", /* 0x60800000 */
> + .data = &sc9863a_mm_gate_desc },
> + { .compatible = "sprd,sc9863a-mm-clk", /* 0x60900000 */
> + .data = &sc9863a_mm_clk_desc },
> + { .compatible = "sprd,sc9863a-vspahb-gate", /* 0x62000000 */
> + .data = &sc9863a_vspahb_gate_desc },
> + { .compatible = "sprd,sc9863a-apapb-gate", /* 0x71300000 */
> + .data = &sc9863a_apapb_gate_desc },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, sprd_sc9863a_clk_ids);
> +
> +static int sc9863a_clk_probe(struct platform_device *pdev)
> +{
> + const struct of_device_id *match;
> + const struct sprd_clk_desc *desc;
> +
> + match = of_match_node(sprd_sc9863a_clk_ids, pdev->dev.of_node);
> + if (!match) {
> + pr_err("%s: of_match_node() failed", __func__);
> + return -ENODEV;
> + }

Use device_get_match_data() instead.

> +
> + desc = match->data;
> + sprd_clk_regmap_init(pdev, desc);
> +
> + return sprd_clk_probe(&pdev->dev, desc->hw_clks);
> +}
> +
> +static struct platform_driver sc9863a_clk_driver = {
> + .probe = sc9863a_clk_probe,
> + .driver = {
> + .name = "sc9863a-clk",
> + .of_match_table = sprd_sc9863a_clk_ids,
> + },
> +};
> +module_platform_driver(sc9863a_clk_driver);
> +
> +MODULE_DESCRIPTION("Spreadtrum SC9863A Clock Driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:sc9863a-clk");

Drop the module alias, it doesn't help from what I can recall.

Next message: Rafael J. Wysocki: "Re: [PATCH RFC 3/3] cpuidle: Use the latency to call find_deepest_idle_state"
Previous message: Stephen Boyd: "Re: [PATCH 1/5] clk: sprd: add gate for pll clocks"
Next in thread: Chunyan Zhang: "Re: [PATCH 5/5] clk: sprd: add clocks support for SC9863A"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]