Re: linux-next boot error: general protection fault in __x64_sys_settimeofday

[Dmitry Vyukov]

On Thu, Nov 14, 2019 at 2:38 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Thu, Nov 14, 2019 at 2:28 PM Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:
> > On Thu, Nov 14, 2019 at 2:22 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > > On Thu, Nov 14, 2019 at 1:43 PM Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:
> > > > On Thu, Nov 14, 2019 at 1:42 PM Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:
> > > > > On Thu, Nov 14, 2019 at 1:35 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > > > > >
> > > > > > On Thu, 14 Nov 2019, syzbot wrote:
> > > > > >
> > > > > > From the full console output:
> > >
> > > > >
> > > > > Urgently need +Jann's patch to better explain these things!
> > > >
> > > > +Arnd, this does not look right:
> > > >
> > > > commit adde74306a4b05c04dc51f31a08240faf6e97aa9
> > > > Author: Arnd Bergmann <arnd@xxxxxxxx>
> > > > Date:   Wed Aug 15 20:04:11 2018 +0200
> > > >
> > > >     y2038: time: avoid timespec usage in settimeofday()
> > > > ...
> > > >
> > > > -               if (!timeval_valid(&user_tv))
> > > > +               if (tv->tv_usec > USEC_PER_SEC)
> > > >                         return -EINVAL;
> > >
> > > Thanks for the report!
> > >
> > > I was checking the wrong variable, fixed now,
> > > should push it out to my y2038 branch in a bit.
> > >
> > >       Arnd
> >
> >
> > This part from the original reporter was lost along the way:
> >
> > IMPORTANT: if you fix the bug, please add the following tag to the commit:
> > Reported-by: syzbot+dccce9b26ba09ca49966@xxxxxxxxxxxxxxxxxxxxxxxxx
> >
> > https://github.com/google/syzkaller/blob/master/docs/syzbot.md#rebuilt-treesamended-patches

/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\
this

> Is there a recommended way to give credit to sysbot if the bug only
> existed briefly in linux-next? Simply listing Reported-by would be wrong
> when I fold the fix into my patch, and it also doesn't seem right to
> leave it as a separate patch while I'm still rebasing the branch.
>
>       Arnd