Re: [PATCH 3/3 v9] kexec: Fix i386 build warnings that missed declaration of struct kimage

From: Borislav Petkov
Date: Thu Nov 14 2019 - 09:44:00 EST


On Thu, Nov 14, 2019 at 10:20:42PM +0800, lijiang wrote:
> I really saw my building result, but kbuild reported the following messages:
>
> vim +5 arch/x86/include/asm/crash.h
>
> dd5f726076cc76 Vivek Goyal 2014-08-08 4
> dd5f726076cc76 Vivek Goyal 2014-08-08 @5 int crash_load_segments(struct kimage *image);
> dd5f726076cc76 Vivek Goyal 2014-08-08 6 int crash_copy_backup_region(struct kimage *image);
> dd5f726076cc76 Vivek Goyal 2014-08-08 7 int crash_setup_memmap_entries(struct kimage *image,
> dd5f726076cc76 Vivek Goyal 2014-08-08 8 struct boot_params *params);
> 89f579ce99f7e0 Yi Wang 2018-11-22 9 void crash_smp_send_stop(void);
> dd5f726076cc76 Vivek Goyal 2014-08-08 10
>
> :::::: The code at line 5 was first introduced by commit
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> :::::: dd5f726076cc7639d9713b334c8c133f77c6757a kexec: support for kexec on panic using new system call
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

You should not take the report of a bot blindly but should always double
check it. Like every other computer system programmed by humans, it can
make mistakes.

> Would you mind giving me any suggestions about this?

I'll take care of it all and push the results out soon.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette