Re: [PATCH v2 1/5] dt-bindings: arm: Convert sprd board/soc bindings to json-schema

From: Rob Herring
Date: Thu Nov 14 2019 - 14:19:31 EST


On Mon, Nov 11, 2019 at 05:02:26PM +0800, Chunyan Zhang wrote:
>
> Convert Unisoc (formerly Spreadtrum) SoC bindings to DT schema format
> using json-schema.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
> ---
> .../devicetree/bindings/arm/sprd.txt | 14 ---------
> .../devicetree/bindings/arm/sprd.yaml | 29 +++++++++++++++++++
> 2 files changed, 29 insertions(+), 14 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/sprd.txt
> create mode 100644 Documentation/devicetree/bindings/arm/sprd.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt
> deleted file mode 100644
> index 3df034b13e28..000000000000
> --- a/Documentation/devicetree/bindings/arm/sprd.txt
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -Spreadtrum SoC Platforms Device Tree Bindings
> -----------------------------------------------------
> -
> -SC9836 openphone Board
> -Required root node properties:
> - - compatible = "sprd,sc9836-openphone", "sprd,sc9836";
> -
> -SC9860 SoC
> -Required root node properties:
> - - compatible = "sprd,sc9860"
> -
> -SP9860G 3GFHD Board
> -Required root node properties:
> - - compatible = "sprd,sp9860g-1h10", "sprd,sc9860";
> diff --git a/Documentation/devicetree/bindings/arm/sprd.yaml b/Documentation/devicetree/bindings/arm/sprd.yaml
> new file mode 100644
> index 000000000000..8540758188d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/sprd.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: GPL-2.0

You made all the commits to the old file, so can you dual license:

# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

With that:

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> +# Copyright 2019 Unisoc Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/sprd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc platforms device tree bindings
> +
> +maintainers:
> + - Orson Zhai <orsonzhai@xxxxxxxxx>
> + - Baolin Wang <baolin.wang7@xxxxxxxxx>
> + - Chunyan Zhang <zhang.lyra@xxxxxxxxx>
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - sprd,sc9836-openphone
> + - const: sprd,sc9836
> + - items:
> + - enum:
> + - sprd,sp9860g-1h10
> + - const: sprd,sc9860
> +
> +...
> --
> 2.20.1
>
>