Re: [PATCH] fs: ext4: remove unused variable warning in parse_options()
From: Theodore Y. Ts'o
Date: Thu Nov 14 2019 - 17:59:53 EST
On Tue, Nov 12, 2019 at 09:53:39PM +0530, Ritesh Harjani wrote:
>
>
> On 11/11/19 7:55 AM, Olof Johansson wrote:
> > Commit c33fbe8f673c5 ("ext4: Enable blocksize < pagesize for
> > dioread_nolock") removed the only user of 'sbi' outside of the ifdef,
> > so it caused a new warning:
> >
> > fs/ext4/super.c:2068:23: warning: unused variable 'sbi' [-Wunused-variable]
> >
> > Fixes: c33fbe8f673c5 ("ext4: Enable blocksize < pagesize for dioread_nolock")
> > Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
>
> hmm, I see that I had CONFIG_QUOTA enabled, so missed this.
> Thanks for the patch.
>
> You may add:
> Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx>
Thanks, applied.
- Ted