Re: [PATCH v4 45/47] net/wan/fsl_ucc_hdlc: reject muram offsets above 64K
From: Timur Tabi
Date: Thu Nov 14 2019 - 23:42:44 EST
On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes
<linux@xxxxxxxxxxxxxxxxxx> wrote:
> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 8d13586bb774..f029eaa7cfc0 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -245,6 +245,11 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)
> ret = -ENOMEM;
> goto free_riptr;
> }
> + if (riptr != (u16)riptr || tiptr != (u16)tiptr) {
"riptr/tiptr > U16_MAX" is clearer.