Re: [PATCH] crypto: hisilicon: no need to check return value of debugfs_create functions

From: Herbert Xu
Date: Fri Nov 15 2019 - 01:06:45 EST


On Thu, Nov 07, 2019 at 09:52:00AM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Zhou Wang <wangzhou1@xxxxxxxxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: linux-crypto@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/crypto/hisilicon/qm.c | 19 +++++--------------
> drivers/crypto/hisilicon/zip/zip_main.c | 24 ++++++------------------
> 2 files changed, 11 insertions(+), 32 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt