Re: [PATCH v1 2/2] mfd: syscon: Switch to use devm_ioremap_resource()

[Andy Shevchenko]

On Fri, Nov 15, 2019 at 10:12:57AM +0100, Arnd Bergmann wrote:
> On Fri, Nov 15, 2019 at 9:49 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > Instead of checking resource pointer for being NULL and
> > report some not very standard error codes in this case,
> > switch to devm_ioremap_resource() API.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> IIRC there are some slightly odd uses of syscon that rely on on us not calling
> devm_request_mem_region here, which is implied by devm_ioremap_resource()
> but not devm_ioremap().

Ah, I see.

> A patch to add a comment about this might be helpful though.

I think the comment won't help if there are overlapping regions are in use.
Probably no need to apply this for now.

-- 
With Best Regards,
Andy Shevchenko