Re: [PATCH v4] sched/freq: move call to cpufreq_update_util

From: Peter Zijlstra
Date: Fri Nov 15 2019 - 05:41:52 EST


On Fri, Nov 15, 2019 at 11:03:20AM +0100, Rafael J. Wysocki wrote:
> On Fri, Nov 15, 2019 at 10:55 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > So why are we making the scheduler code more ugly instead of fixing that
> > driver?
>
> I guess we could "fix" the driver by making it rate limit MSR writes
> only, but I'm not sure if that would help.

So it is not clear to me what exactly intel_pstate needs and why. Like I
wrote in my reply to Vincent just now, it can still store the last
value, even if it doesn't act on it right away.

And it can then act on that stored value at a later event, whatever is
appropriate.

I'm just saying that generating superfluous events is silly. But
possibly I read the patch wrong.